Allow placeholder validation for write queries (staabm#506)

Co-authored-by: Markus Staab <[email protected]>

Author: hemberger

src/QueryReflection/PlaceholderValidation.php

@@ -32,10 +32,6 @@ public function checkQuery(Expr $queryExpr, Scope $scope, array $parameters): it
      */
     private function checkErrors(string $queryString, array $parameters): iterable
     {
-        if ('SELECT' !== QueryReflection::getQueryType($queryString)) {
-            return;
-        }
-
         $queryReflection = new QueryReflection();
         if ($queryReflection->containsNamedPlaceholders($queryString, $parameters)) {
             yield from $this->validateNamedPlaceholders($queryString, $parameters);

tests/rules/SyntaxErrorInPreparedStatementMethodRuleTest.php

@@ -82,6 +82,10 @@ public function testSyntaxErrorInQueryRule(): void
                     "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'gesperrt freigabe1u1 FROM ada LIMIT 0' at line 1 (1064).",
                     319,
                 ],
+                [
+                    'Query expects placeholder :freigabe1u1, but it is missing from values given.',
+                    325,
+                ],
             ];
         } elseif (PdoPgSqlQueryReflector::NAME === getenv('DBA_REFLECTOR')) {
             $expectedErrors = [
@@ -157,6 +161,10 @@ public function testSyntaxErrorInQueryRule(): void
                            ^ (42601).',
                     319,
                 ],
+                [
+                    'Query expects placeholder :freigabe1u1, but it is missing from values given.',
+                    325,
+                ],
             ];
         } elseif (PdoMysqlQueryReflector::NAME === getenv('DBA_REFLECTOR')) {
             $expectedErrors = [
@@ -208,6 +216,10 @@ public function testSyntaxErrorInQueryRule(): void
                     "Query error: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'gesperrt freigabe1u1 FROM ada LIMIT 0' at line 1 (42000).",
                     319,
                 ],
+                [
+                    'Query expects placeholder :freigabe1u1, but it is missing from values given.',
+                    325,
+                ],
             ];
         } else {
             throw new \RuntimeException('Unsupported DBA_REFLECTOR '.getenv('DBA_REFLECTOR'));