Skip to content

Commit 4e1070f

Browse files
committed
remove some unnecessary typecasts in tests
(there's many more like these, of course!)
1 parent 0f80280 commit 4e1070f

File tree

5 files changed

+15
-20
lines changed

5 files changed

+15
-20
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/associations/any/AnyTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public void testMetaAnnotated() {
8989
final PropertyHolder2 propertyHolder = session.get( PropertyHolder2.class, 2L );
9090
assertEquals( "name2", propertyHolder.getProperty().getName() );
9191
assertEquals( "Mario Rossi", propertyHolder.getProperty().getValue() );
92-
final String propertyType = (String) session.createNativeQuery(
92+
final String propertyType = session.createNativeQuery(
9393
"select property_type from property_holder2",
9494
String.class
9595
).getSingleResult();

hibernate-core/src/test/java/org/hibernate/orm/test/flush/AutoFlushTest.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,8 @@ public void testFlushAutoSQLNativeSession() {
129129
// or using Hibernate's FlushMode enum
130130
//session.setHibernateFlushMode(FlushMode.COMMIT);
131131

132-
assertTrue(((Number) session
133-
.createNativeQuery("select count(*) from Person", Integer.class)
134-
.uniqueResult()).intValue() == 0);
132+
assertTrue( session.createNativeQuery( "select count(*) from Person", Integer.class )
133+
.uniqueResult() == 0);
135134
//end::flushing-auto-flush-sql-native-example[]
136135
});
137136
}
@@ -152,10 +151,9 @@ public void testFlushAutoSQLSynchronization() {
152151
entityManager.persist(person);
153152
Session session = entityManager.unwrap(Session.class);
154153

155-
assertTrue(((Number) session
156-
.createNativeQuery("select count(*) from Person", Integer.class)
157-
.addSynchronizedEntityClass(Person.class)
158-
.uniqueResult()).intValue() == 1);
154+
assertTrue( session.createNativeQuery( "select count(*) from Person", Integer.class )
155+
.addSynchronizedEntityClass( Person.class )
156+
.uniqueResult() == 1);
159157
//end::flushing-auto-flush-sql-synchronization-example[]
160158
});
161159
}

hibernate-core/src/test/java/org/hibernate/orm/test/flush/HibernateAutoFlushTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,14 @@ public void testFlushAutoSQLNativeSession() {
3535
doInHibernate(this::sessionFactory, session -> {
3636
log.info("testFlushAutoSQLNativeSession");
3737
//tag::flushing-auto-flush-sql-native-example[]
38-
assertTrue(((Number) session
39-
.createNativeQuery("select count(*) from Person", Integer.class)
40-
.getSingleResult()).intValue() == 0);
38+
assertTrue( session.createNativeQuery( "select count(*) from Person", Integer.class )
39+
.getSingleResult() == 0);
4140

4241
Person person = new Person("John Doe");
4342
session.persist(person);
4443

45-
assertTrue(((Number) session
46-
.createNativeQuery("select count(*) from Person", Integer.class)
47-
.uniqueResult()).intValue() == 0);
44+
assertTrue( session.createNativeQuery( "select count(*) from Person", Integer.class )
45+
.uniqueResult() == 0);
4846
//end::flushing-auto-flush-sql-native-example[]
4947
});
5048
}

hibernate-core/src/test/java/org/hibernate/orm/test/flush/ManualFlushTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,8 @@ public void testFlushSQL() {
5555
.createQuery("select count(id) from Person")
5656
.getSingleResult()).intValue() == 0);
5757

58-
assertTrue(((Number) session
59-
.createNativeQuery("select count(*) from Person", Integer.class)
60-
.uniqueResult()).intValue() == 0);
58+
assertTrue( session.createNativeQuery( "select count(*) from Person", Integer.class )
59+
.uniqueResult() == 0);
6160
//end::flushing-manual-flush-example[]
6261
});
6362
}

hibernate-core/src/test/java/org/hibernate/orm/test/multitenancy/DatabaseTimeZoneMultiTenancyTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public void testBasicExpectedBehavior() {
137137
}, true);
138138

139139
doInSession(FRONT_END_TENANT, session -> {
140-
Timestamp personCreationTimestamp = (Timestamp) session
140+
Timestamp personCreationTimestamp = session
141141
.createNativeQuery(
142142
"select p.created_on " +
143143
"from Person p " +
@@ -152,7 +152,7 @@ public void testBasicExpectedBehavior() {
152152
}, true);
153153

154154
doInSession(BACK_END_TENANT, session -> {
155-
Timestamp personCreationTimestamp = (Timestamp) session
155+
Timestamp personCreationTimestamp = session
156156
.createNativeQuery(
157157
"select p.created_on " +
158158
"from Person p " +
@@ -169,7 +169,7 @@ public void testBasicExpectedBehavior() {
169169

170170
//tag::multitenacy-hibernate-not-applying-timezone-configuration-example[]
171171
doInSession(FRONT_END_TENANT, session -> {
172-
Timestamp personCreationTimestamp = (Timestamp) session
172+
Timestamp personCreationTimestamp = session
173173
.createNativeQuery(
174174
"select p.created_on " +
175175
"from Person p " +

0 commit comments

Comments
 (0)