Added jUnits. Changed the logic when the block is on found.

Signed-off-by: a-saksena <[email protected]>

Author: a-saksena

server/src/main/java/com/hedera/block/server/BlockStreamService.java

@@ -156,12 +156,11 @@ private StreamObserver<BlockStreamServiceGrpcProto.BlockResponse> streamSource(
         return streamObserver;
     }
 
-    private void getBlock(
+    void getBlock(
             BlockStreamServiceGrpcProto.Block block,
             StreamObserver<BlockStreamServiceGrpcProto.Block> responseObserver) {
-        String message = "GET BLOCK RESPONSE! ";
         LOGGER.log(System.Logger.Level.INFO, "GetBlock request received");
-        Optional<BlockStreamServiceGrpcProto.Block> responseBlock =
+        final Optional<BlockStreamServiceGrpcProto.Block> responseBlock =
                 blockPersistenceHandler.read(block.getId());
         if (responseBlock.isPresent()) {
             LOGGER.log(System.Logger.Level.INFO, "SENDING BLOCK # " + block.getId());
@@ -170,13 +169,7 @@ private void getBlock(
                     responseBlock.get()); // TODO: Should return int and not quoted string
         } else {
             LOGGER.log(System.Logger.Level.INFO, "DID NOT FIND YOUR BLOCK");
-            // TODO: Fix below. It could return gRPC equivalent of 404 NOT FOUND
-            responseObserver.onError(
-                    Status.NOT_FOUND
-                            .withDescription("DID NOT FIND YOUR BLOCK")
-                            .asRuntimeException());
-            // Keeping below comments for the fix needed above.
-            // complete(responseObserver, BlockStreamServiceGrpcProto.Block.getDefaultInstance());
+            responseObserver.onNext(BlockStreamServiceGrpcProto.Block.newBuilder().setId(0).build());
         }
     }
 }

server/src/test/java/com/hedera/block/server/BlockStreamServiceTest.java

@@ -0,0 +1,53 @@
+package com.hedera.block.server;
+
+import com.hedera.block.protos.BlockStreamServiceGrpcProto;
+import com.hedera.block.server.mediator.StreamMediator;
+import com.hedera.block.server.persistence.BlockPersistenceHandler;
+import io.grpc.Status;
+import io.grpc.stub.StreamObserver;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.util.Optional;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.*;
+
+@ExtendWith(MockitoExtension.class)
+class BlockStreamServiceTest {
+
+    private final long TIMEOUT_THRESHOLD_MILLIS = 52L;
+
+
+    @Mock
+    private StreamObserver<BlockStreamServiceGrpcProto.Block> responseObserver;
+
+    @Mock
+    private BlockPersistenceHandler<BlockStreamServiceGrpcProto.Block> blockPersistenceHandler;
+
+    @Mock
+    private StreamMediator<
+                BlockStreamServiceGrpcProto.Block,
+                BlockStreamServiceGrpcProto.BlockResponse>
+            streamMediator;
+
+    @Test
+    void getBlockHappyPath() {
+        BlockStreamServiceGrpcProto.Block block = BlockStreamServiceGrpcProto.Block.newBuilder().setId(1).build();
+        BlockStreamService blockStreamService = new BlockStreamService(TIMEOUT_THRESHOLD_MILLIS, streamMediator, blockPersistenceHandler);
+        when(blockPersistenceHandler.read(1)).thenReturn(Optional.of(BlockStreamServiceGrpcProto.Block.newBuilder().setId(1).build()));
+        blockStreamService.getBlock(block, responseObserver);
+        verify(responseObserver, times(1)).onNext(block);
+    }
+
+    @Test
+    void getBlockErrorPath() {
+        BlockStreamServiceGrpcProto.Block block = BlockStreamServiceGrpcProto.Block.newBuilder().setId(1).build();
+        BlockStreamService blockStreamService = new BlockStreamService(TIMEOUT_THRESHOLD_MILLIS, streamMediator, blockPersistenceHandler);
+        when(blockPersistenceHandler.read(1)).thenReturn(Optional.empty());
+        blockStreamService.getBlock(block, responseObserver);
+        verify(responseObserver, times(1)).onNext(BlockStreamServiceGrpcProto.Block.newBuilder().setId(0).build());
+    }
+}