From 6cfa076f2c2ef62265c55debad179b896a55e2a7 Mon Sep 17 00:00:00 2001 From: Atanas Atanasov Date: Wed, 5 Mar 2025 11:05:20 +0200 Subject: [PATCH] todo updates Signed-off-by: Atanas Atanasov --- .../java/com/hedera/block/server/ack/AckHandlerImpl.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/src/main/java/com/hedera/block/server/ack/AckHandlerImpl.java b/server/src/main/java/com/hedera/block/server/ack/AckHandlerImpl.java index da6645140..d2b889c6e 100644 --- a/server/src/main/java/com/hedera/block/server/ack/AckHandlerImpl.java +++ b/server/src/main/java/com/hedera/block/server/ack/AckHandlerImpl.java @@ -70,10 +70,11 @@ public void blockPersisted(@NonNull final BlockPersistenceResult blockPersistenc final BlockInfo info = blockInfo.computeIfAbsent(blockNumber, BlockInfo::new); info.getBlockStatus().setPersisted(); } else { - // @todo(743) handle other cases for the blockPersistenceResult + // @todo(774) handle other cases for the blockPersistenceResult // for now we will simply send an end of stream message // but more things need to be handled, like ensure the - // blockInfo map will not be inserted + // blockInfo map will not be inserted. We should use a + // persistence failed response code as well. blockVerificationFailed(blockNumber); blockInfo.remove(blockNumber); } @@ -159,8 +160,7 @@ private void attemptAcks() { // remove the info from the map. This means that the data needs to be requested // again. What would be the best way to hande inability to move the block with // the limitations we current have? - // @todo(743) we should think of a response code for unsuccessful persistence - // this is outside of the scope of this PR + // @todo(774) we should use a response code for failed persistence here blockVerificationFailed(nextBlock); return; }