increasing UT Coverage for edge cases for diff number

Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
hiero-ledger · Mar 11, 2025 · 7738e4e · 7738e4e
1 parent 04f0375
commit 7738e4e
Showing 1 changed file with 46 additions and 0 deletions.
diff --git a/server/src/test/java/org/hiero/block/server/producer/ProducerBlockItemObserverTest.java b/server/src/test/java/org/hiero/block/server/producer/ProducerBlockItemObserverTest.java
@@ -331,6 +331,52 @@ public void testDuplicateBlockReceived_NullAckVariation() {
         verify(publisher, never()).publish(any());
     }
 
+    @Test
+    @DisplayName("Test duplicate block items with different ACK number variation")
+    public void testDuplicateBlockReceived_DiffAckNumberVariation() {
+
+        // given
+        when(serviceStatus.isRunning()).thenReturn(true);
+        long latestAckedBlockNumber = 10L;
+        long latestReceivedBlockNumber = 11L;
+        Bytes fakeHash = Bytes.wrap("fake_hash");
+        BlockInfo latestAckedBlock = new BlockInfo(latestAckedBlockNumber);
+        latestAckedBlock.setBlockHash(fakeHash);
+        when(serviceStatus.getLatestAckedBlock()).thenReturn(latestAckedBlock);
+        when(serviceStatus.getLatestReceivedBlockNumber()).thenReturn(latestReceivedBlockNumber);
+
+        final List<BlockItemUnparsed> blockItems = generateBlockItemsUnparsedForWithBlockNumber(latestReceivedBlockNumber);
+        final ProducerBlockItemObserver producerBlockItemObserver = new ProducerBlockItemObserver(
+                testClock,
+                publisher,
+                subscriptionHandler,
+                helidonPublishPipeline,
+                serviceStatus,
+                consumerConfig,
+                metricsService);
+
+        // when
+        producerBlockItemObserver.onNext(blockItems);
+
+        // then
+        final BlockAcknowledgement blockAcknowledgement = BlockAcknowledgement.newBuilder()
+                .blockNumber(latestReceivedBlockNumber)
+                .blockAlreadyExists(true)
+                .build();
+
+        final Acknowledgement acknowledgement =
+                Acknowledgement.newBuilder().blockAck(blockAcknowledgement).build();
+
+        final PublishStreamResponse publishStreamResponse = PublishStreamResponse.newBuilder()
+                .acknowledgement(acknowledgement)
+                .build();
+
+        // verify helidonPublishPipeline.onNext() is called once with publishStreamResponse
+        verify(helidonPublishPipeline, timeout(testTimeout).times(1)).onNext(publishStreamResponse);
+        // verify that the duplicate block is not published
+        verify(publisher, never()).publish(any());
+    }
+
     @Test
     @DisplayName("Test future (ahead of expected) block received")
     public void testFutureBlockReceived() {