Skip to content

Publisher API is missing some request forms #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jsync-swirlds opened this issue May 15, 2025 · 0 comments · May be fixed by #1152
Open

Publisher API is missing some request forms #1151

jsync-swirlds opened this issue May 15, 2025 · 0 comments · May be fixed by #1152
Assignees
@jsync-swirlds
Milestone
0.11.0

Comments

@jsync-swirlds
Copy link
Contributor

jsync-swirlds commented May 15, 2025 •
edited
Loading

Description

The publish protocol documentation here describes several scenarios in the Publisher <-> Block Node communication that require the Publisher to send an EndStream message (different from the response EndOfStream message). This is missing from the latest protocol buffer API definition, and needs to be added back in.

Steps to Reproduce

This was encountered during discussion with hiero-consensus-node engineers who were confused by the missing API elements.
@jsync-swirlds jsync-swirlds added this to the 0.11.0 milestone May 15, 2025
@jsync-swirlds jsync-swirlds self-assigned this May 15, 2025
jsync-swirlds added a commit that referenced this issue May 15, 2025
@jsync-swirlds
fix: Publisher API is missing some request forms
2671390 
* Added the missing `EndStream` item for publish request
* Moved publish end stream code and response end stream code into their respective messages
* Removed `Acknowledgement` wrapper around `BlockAcknowledgement`.
* Removed unnecessary enum name prefixes
* Discovered another PBJ bug (unit tests generation) related to message name conflicts
* Fixed all references in code and tests

Fixes #1151

Signed-off-by: Joseph S <[email protected]>
jsync-swirlds added a commit that referenced this issue May 15, 2025
@jsync-swirlds
fix: Publisher API is missing some request forms
f5aa7b8 
* Added the missing `EndStream` item for publish request
   * Note, this does _not_ implement handling for this new message; it only adds the API definitions.
* Moved publish end stream code and response end stream code into their respective messages
* Removed `Acknowledgement` wrapper around `BlockAcknowledgement`.
* Removed unnecessary enum name prefixes
* Discovered another PBJ bug (unit tests generation) related to message name conflicts
* Fixed all references in code and tests

Fixes #1151

Signed-off-by: Joseph S <[email protected]>
@jsync-swirlds jsync-swirlds linked a pull request May 15, 2025 that will close this issue
Open
jsync-swirlds added a commit that referenced this issue May 15, 2025
@jsync-swirlds
fix: Publisher API is missing some request forms
e5764da 
* Added the missing `EndStream` item for publish request
   * Note, this does _not_ implement handling for this new message; it only adds the API definitions.
* Moved publish end stream code and response end stream code into their respective messages
* Removed `Acknowledgement` wrapper around `BlockAcknowledgement`.
* Removed unnecessary enum name prefixes
* Discovered another PBJ bug (unit tests generation) related to message name conflicts
* Fixed all references in code and tests

Fixes #1151

Signed-off-by: Joseph S <[email protected]>
@jsync-swirlds jsync-swirlds mentioned this issue May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsync-swirlds jsync-swirlds

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

fix: Publisher API is missing some request forms hiero-ledger/hiero-block-node
1 participant
@jsync-swirlds