Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unverified blocks root #582

Closed
ata-nas opened this issue Feb 5, 2025 · 0 comments · Fixed by #715
Closed

Add unverified blocks root #582

ata-nas opened this issue Feb 5, 2025 · 0 comments · Fixed by #715
Assignees
Labels
P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Milestone

Comments

@ata-nas
Copy link
Contributor

ata-nas commented Feb 5, 2025

Instead of storing block files directly in the local destination, we wish to modify the block writers as follows:

  1. Store block files initially in an "unverified" folder, just flat with full file name.
  2. A separate process initiated when a result is published by the verification service will move the file.
    • When a "verified" result is published this will move the now-verified block (only) to its proper destination
    • When an "unverified" result is published, this will remove the now-failed block (only).
    • When other result types are published this sub-service will only react if appropriate.
  3. On startup, the persistence service will remove all unverified files.
    • This might be accomplished by using a folder on tmpfs, which is managed in-memory by the kernel and would significantly improve reliability and performance.
  4. All other persistence service elements, and all archive services, will operate only on the trie structure folders containing verified block files.
@ata-nas ata-nas self-assigned this Feb 5, 2025
@ata-nas ata-nas added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. Block Node Issues/PR related to the Block Node. Alpha-0 Issues related to features designated for the Alpha-0 release labels Feb 5, 2025
@ata-nas ata-nas changed the title Add unverified marker for persisted block files feat: add unverified marker for persisted block files Feb 5, 2025
@ata-nas ata-nas added this to the 0.4.0 milestone Feb 5, 2025
@jsync-swirlds jsync-swirlds removed New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. Block Node Issues/PR related to the Block Node. Alpha-0 Issues related to features designated for the Alpha-0 release labels Feb 5, 2025
@jsync-swirlds jsync-swirlds modified the milestones: 0.4.0, 0.5.0 Feb 5, 2025
@AlfredoG87 AlfredoG87 modified the milestones: 0.5.0, 0.6.0 Feb 21, 2025
@ata-nas ata-nas linked a pull request Feb 25, 2025 that will close this issue
@ata-nas ata-nas changed the title feat: add unverified marker for persisted block files feat: add unverified blocks root Feb 27, 2025
@ata-nas ata-nas changed the title feat: add unverified blocks root Add unverified blocks root Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants