Persona

As a Block Node Developer

Request

I want to have repeatable tests whenever possible

Goal

So that the tests are not flaky and will not hinder CI/CD

Technical Notes

Since the development of new async block writers, it became evident that there are some tests failing because some logic runs async. Simply by the time we reach the asserts, the logic that would produce the desired results for the asserts is not yet finished. We should make these (and similar) tests repeatable in the sense that we should ensure that the async tasks have enough time to complete before we do the asserts.

• an idea is to inject an executor that will allow us to wait for the tasks to complete, blocking the test thread

Tests that were disabled and need migration:

• com.hedera.block.server.pbj.PbjBlockStreamServiceIntegrationTest#testFullProducerConsumerHappyPath
• com.hedera.block.server.pbj.PbjBlockStreamServiceIntegrationTest#testPublishBlockStreamRegistrationAndExecution
• com.hedera.block.server.mediator.LiveStreamMediatorImplTest#testMediatorPersistenceWithoutSubscribers

Considerations:

• based on this thread consider to use jimfs and/ or mocks