Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only Zstd Compression #768

Open
ata-nas opened this issue Mar 4, 2025 · 0 comments
Open

Support only Zstd Compression #768

ata-nas opened this issue Mar 4, 2025 · 0 comments
Labels
Block Node Issues/PR related to the Block Node. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Comments

@ata-nas
Copy link
Contributor

ata-nas commented Mar 4, 2025

Persona

As a Block Node Developer/Operator

Request

I want to for now only support zstd compression type

Goal

So that the code is simpler and easier to manage

Technical Notes

  • we currently envision that we will only need to use zstd compression
  • we should simplify the current reading, writing and path resolution logic
  • we should only support zstd compression for now, adding additional compression types only if needed in the future
  • the strategy should be to check for a magic number to determine the type of compression and attempting to decompress and read based on the magic number result, falling back to uncompressed if failed. (we could start only with zstd directly in the beginning?)
  • what needs to be done:
    • drop the support for compression types other than zstd for now
    • remove block extensions for compression, blocks should just end with .blk, checking for magic number is far more reliable
    • the wrapper classes for live, archive and unverified paths will become redundant, should be simplified to a resolved Path
@ata-nas ata-nas added Block Node Issues/PR related to the Block Node. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Development

No branches or pull requests

1 participant