chore: exposed a GRPC Service (endpoint) for the ServerStatus API #812
+368
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Sawarkar <[email protected]>
Signed-off-by: Harsh Sawarkar <[email protected]>
AlfredoG87
reviewed
Mar 10, 2025
| @@ -1,4 +1,4 @@ | |||
| #·SPDX-License-Identifier:·Apache-2.0 | |||
There was a problem hiding this comment.
looks like IDE style changes that should not be commited.
| @@ -63,6 +66,7 @@ public BlockNodeApp( | |||
| this.pbjBlockStreamService = requireNonNull(pbjBlockStreamService); | |||
| this.pbjBlockAccessService = requireNonNull(pbjBlockAccessService); | |||
| this.webServerBuilder = requireNonNull(webServerBuilder); | |||
| this.pbjServerStatusService = pbjServerStatusService; | |||
There was a problem hiding this comment.
Suggested change
| this.pbjServerStatusService = pbjServerStatusService; | |
| this.pbjServerStatusService = Objects.requireNonNull(pbjServerStatusService); |
Comment on lines
12
to
31
| public interface PbjServerStatusService extends ServiceInterface { | ||
| enum ServerStatusMethod implements Method { | ||
| serverStatus | ||
| } | ||
|
|
||
| @NonNull | ||
| default String serviceName() { | ||
| return SERVICE_NAME_BLOCK_NODE; | ||
| } | ||
|
|
||
| @NonNull | ||
| default String fullName() { | ||
| return FULL_SERVICE_NAME_BLOCK_NODE; | ||
| } | ||
|
|
||
| @NonNull | ||
| default List<Method> methods() { | ||
| return Arrays.asList(PbjServerStatusService.ServerStatusMethod.values()); | ||
| } | ||
| } |
Comment on lines
41
to
43
| this.serviceStatus = serviceStatus; | ||
| this.blockReader = blockReader; | ||
| this.metricsService = metricsService; |
|
|
||
| private final ServiceStatus serviceStatus; | ||
| private final BlockReader<BlockUnparsed> blockReader; | ||
| private final MetricsService metricsService; |
There was a problem hiding this comment.
are we using the metrics?
We should be observing the amount of request we get, and if there were errors.
Comment on lines
+61
to
+62
| () -> getBlockAsFileBlockStreamManager( | ||
| getAbsoluteFolder("build/resources/test//BlockAsDirException/1/"))); |
Signed-off-by: Harsh Sawarkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
PbjServerStatusServiceProxyto expose server status api endpoint.Related Issue(s)
Fixes #777