-
Notifications
You must be signed in to change notification settings - Fork 9
chore: exposed a GRPC Service (endpoint) for the ServerStatus API #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harsh Sawarkar <[email protected]>
Signed-off-by: Harsh Sawarkar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass, I know is still in draft.
In General is missing a lot of Javadocs.
@@ -1,4 +1,4 @@ | |||
#·SPDX-License-Identifier:·Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like IDE style changes that should not be commited.
@@ -63,6 +66,7 @@ public BlockNodeApp( | |||
this.pbjBlockStreamService = requireNonNull(pbjBlockStreamService); | |||
this.pbjBlockAccessService = requireNonNull(pbjBlockAccessService); | |||
this.webServerBuilder = requireNonNull(webServerBuilder); | |||
this.pbjServerStatusService = pbjServerStatusService; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.pbjServerStatusService = pbjServerStatusService; | |
this.pbjServerStatusService = Objects.requireNonNull(pbjServerStatusService); |
server/src/main/java/com/hedera/block/server/pbj/PbjServerStatusService.java
Outdated
Show resolved
Hide resolved
this.serviceStatus = serviceStatus; | ||
this.blockReader = blockReader; | ||
this.metricsService = metricsService; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing preConditions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
server/src/main/java/com/hedera/block/server/pbj/PbjServerStatusServiceProxy.java
Outdated
Show resolved
Hide resolved
...or/src/test/java/com/hedera/block/simulator/generator/BlockAsFileBlockStreamManagerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harsh Sawarkar <[email protected]>
Signed-off-by: Harsh Sawarkar <[email protected]>
@AlfredoG87 I tried to build the server module but faced below error on the command .
|
Fair Warning: we're restructuring the whole codebase, so probably nothing will work super well at the moment (probably for the next several hours). This particular item is a "module" check, The error provides the exact instructions to fix the issue (remove the two requires lines from the indicated module-info.java file), but do note that this particular error is already being fixed in a different PR. |
Signed-off-by: Harsh Sawarkar <[email protected]>
… into chore-expose-a-GRPC-Service-(endpoint)-for-the-ServerStatus-API-
Signed-off-by: Harsh Sawarkar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few PRs (this included) will likely be delayed and impacted by significant ongoing rewrites of the code base.
I'm blocking the PR for now just to avoid any unintended conflicts and to save you effort.
Once things are in the clear we can decide whether to rebase (if all changes are still applicable), pull some changes into a new PR (in a subset is still applicable) or if to close this underlying ticket if it's no longer applicable.
Thanks for your interest and contributions here, we'll be laying out more tickets that the community can look to to pick up and also exploring how to have community calls to improve the efficiency and sharing of information.
Thanks, @Nana-EC , for your response. I will hold onto this PR, and in the meantime, I will look for other issues to contribute to. I look forward to attending community calls and working and learning in sync with the team. |
@HarshSawarkar feel free to rebase and update if you're able to now that the refactor to |
Team is working on this ticket, using the updated Plugin architecture. |
Reviewer Notes
PbjServerStatusServiceProxy
to expose server status api endpoint.Related Issue(s)
Fixes #777