Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set unique default server port #805

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nana-EC
Copy link
Contributor

@Nana-EC Nana-EC commented Mar 8, 2025

Reviewer Notes

Set a new unique server port 40840 to reduce likelihood of collisions.
Updates cover charts, docker files, config READMEs, serverconfig, tests files and tests bash files

Related Issue(s)

Fixes #800

@Nana-EC Nana-EC added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Mar 8, 2025
@Nana-EC Nana-EC added this to the 0.7.0 milestone Mar 8, 2025
@Nana-EC Nana-EC self-assigned this Mar 8, 2025
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC Nana-EC force-pushed the 800-new-default-server-port branch from cf6635f to 7e8e2df Compare March 8, 2025 06:51
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff            @@
##               main     #805   +/-   ##
=========================================
  Coverage     89.12%   89.12%           
  Complexity      707      707           
=========================================
  Files           130      130           
  Lines          3043     3043           
  Branches        219      219           
=========================================
  Hits           2712     2712           
  Misses          265      265           
  Partials         66       66           
Files with missing lines Coverage Δ Complexity Δ
...ain/java/com/hedera/block/server/ServerConfig.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...hedera/block/simulator/config/data/GrpcConfig.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +4 to +5
kubectl port-forward --namespace {{ .Release.Namespace }} svc/{{.Release.Name}}-{{.Chart.Name}} 40840:{{ .Values.service.port }}
echo "Visit http://127.0.0.1:40840 to use your application"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl port-forward --namespace {{ .Release.Namespace }} svc/{{.Release.Name}}-{{.Chart.Name}} 40840:{{ .Values.service.port }}
echo "Visit http://127.0.0.1:40840 to use your application"
kubectl port-forward --namespace {{ .Release.Namespace }} svc/{{.Release.Name}}-{{.Chart.Name}} {{ .Values.service.port }}:{{ .Values.service.port }}
echo "Visit http://127.0.0.1:{{ .Values.service.port }} to use your application"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set new default server port
2 participants