Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DID SDK compatibility improvements #43

Open
AlexanderShenshin opened this issue Feb 2, 2025 · 3 comments
Open

DID SDK compatibility improvements #43

AlexanderShenshin opened this issue Feb 2, 2025 · 3 comments
Assignees

Comments

@AlexanderShenshin
Copy link
Contributor

Thank you for your great work!
There is a list of problems that impact DID SDK functionality in non-blocking way - it will be great to resolve these to improve compatibility.

The most significant point here is support for ECDSA key type:

  • Current to_bytes_raw method does not work for ECDSA
  • ECDSA raw public key parsing is not implemented (mentioned in recent PR)

There are other issues that are not critical, but nice to have (and will make library more robust):

  • No dispose/close for client class - we probably want to close gRPC channel
  • Related to TopicMessageQuery
    • Topic subscription is not cancellable
      • Java SDK provides a subscription handle that can be used to cancel operation (for example, on error)
      • Java SDK example
    • There is no completion handler for topic subscription, so the caller do not know when all messages have been received
      • "all messages received" is a relative statement, of course, but it will be good for SDK to provide some default logic on that
      • Java SDK example
    • Some query properties/settings are missing comparing to Java SDK
@nadineloepfe nadineloepfe self-assigned this Feb 4, 2025
@nadineloepfe
Copy link
Contributor

nadineloepfe commented Feb 4, 2025

will try to pick this up Thursday or Friday

@nadineloepfe
Copy link
Contributor

PR here:
#50

@AlexanderShenshin

@AlexanderShenshin
Copy link
Contributor Author

@nadineloepfe PR looks good, thank you!

We can close this after PR is merged, I will do more testing of these changes in DID SDK and get back to you if I encounter any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants