-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Composer 2.0.0 #233
Comments
Shall we install prestissimo with Composer 2? Is there any benefits anymore? |
The PR is waiting since April: #223 |
@mhemrg i'm interested in the answer as well, is it an open question from you, or do you have some argument that would show it may be no more needed ? |
@allan-simon I guess there should be no need to use I haven't benchmarked yet, but benchmarks would help a lot to answer this question. |
OK. I just ran some simple benchmarks and I'm going to share the results: Command: Benchmark 1: First run: [570.2MiB/32.66s] Memory usage: 570.24MiB (peak: 1009.54MiB), time: 32.66s Benchmark 2: First run: [74.7MiB/17.03s] Memory usage: 74.74MiB (peak: 196.55MiB), time: 17.03s |
Awesome! thank you for the info. Looks like composer 2 its getting better 🎉 |
Thanks for the benchmark. Removing Prestissimo. |
I removed this plugin after the issues with composer 2, build seems to be faster with composer2. |
We need to arrange funeral? |
@hirak Thank you so much for this project. I can't tell you how much I've appreciated having such tooling in place, used on other projects to speed up build times. |
i made a small PR with a noop mode if this plugin is installed and composer2 is used, should run normally with composer1, please test and comment. see #239 |
@c33s I made a PR to allow Composer 2. even with some tests, but @hirak was not interested: #223 (comment) |
@kubawerlos oh... well. |
This would really help the transition to composer 2! I run dozens of projects on a multitude of servers, CI docker containers and dev environments, and it would be immensely helpful to be able to just update composer everywhere I come by without having to worry whether all projects on that particular machine or using that container for CI have already been dropping |
Composer 2.0.0 has been released 3 hours ago and prestissimo now can't be installed on the new version
https://github.com/composer/composer/releases/tag/2.0.0
The text was updated successfully, but these errors were encountered: