Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming mode doesn't check blocks field on predicate spec #491

Open
MicaiahReid opened this issue Feb 8, 2024 · 0 comments
Open

streaming mode doesn't check blocks field on predicate spec #491

MicaiahReid opened this issue Feb 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@MicaiahReid
Copy link
Contributor

Describe the bug
A predicate spec has an optional field blocks: Vec<u64> where the user provides a specific list of blocks to scan. If some of those blocks are past chain tip, we have to go to streaming mode. However, streaming mode only checks for an end_block so that predicate will be evaluated against every block, not just those in the blocks array.

To Reproduce
Steps to reproduce the behavior:

  1. Create a predicate with blocks field containing blocks that are past chain tip
  2. Observe the scan completing and the predicate entering streaming mode
  3. Observe the predicate being evaluated against every block instead of just those provided in the blocks list.
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Feb 8, 2024
@MicaiahReid MicaiahReid added the bug Something isn't working label Feb 8, 2024
@MicaiahReid MicaiahReid moved this from 🆕 New to 📋 Backlog in DevTools Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant