Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an opinionated formatter #606

Open
obycode opened this issue Mar 3, 2022 · 4 comments · May be fixed by #1609
Open

Add an opinionated formatter #606

obycode opened this issue Mar 3, 2022 · 4 comments · May be fixed by #1609
Assignees
@tippenein

Comments

@obycode
Copy link
Member

obycode commented Mar 3, 2022 •
edited by smcclellan
Loading

It is always useful to have a formatter to fix whitespace and other minor formatting changes in your code. Our VSCode extension should provide a formatter for Clarity files.
@obycode
Copy link
Member Author

obycode commented Jun 6, 2022

I believe the main missing component needed to implement this would be maintaining the comments in the AST. There is currently no data structure to hold comments, so they are treated the same as whitespace in the code. If we add a new PreSymbolicExpressionType for comments, then it should be relatively easy to implement a formatter.

@lgalabru lgalabru transferred this issue from hirosystems/ordhook Oct 18, 2022
@lgalabru
Copy link
Contributor

lgalabru commented Jan 4, 2023

Related #664

@lgalabru lgalabru added this to the Q1-2023 milestone Jan 19, 2023
@hugocaillard hugocaillard moved this from ❄️ Icebox to 🏗 In progress in DevTools Feb 27, 2023
@hugocaillard hugocaillard self-assigned this Feb 27, 2023
@smcclellan smcclellan modified the milestones: Q1-2023, Q2-2023 Mar 24, 2023
@smcclellan smcclellan moved this from 🏗 In progress to 🔖 To do in DevTools Apr 19, 2023
@smcclellan
Copy link
Contributor

@hugocaillard to add more detail here.

@hugocaillard hugocaillard moved this from 🔖 To do to 🏗 In progress in DevTools May 3, 2023
@sabbyanandan sabbyanandan mentioned this issue May 4, 2023
Closed
@hugocaillard hugocaillard moved this from 🏗 In progress to 🔖 To do in DevTools May 5, 2023
@smcclellan smcclellan modified the milestones: Q2-2023, Q3-2023 Jun 27, 2023
@smcclellan smcclellan added icebox and removed icebox labels Jul 7, 2023
@smcclellan smcclellan modified the milestones: Q3-2023, Q4-2023 Sep 14, 2023
@smcclellan smcclellan modified the milestones: Q4-2023, Q1-2024 Jan 16, 2024
@hugocaillard hugocaillard removed this from the Q1-2024 milestone Jun 17, 2024
@smcclellan smcclellan assigned tippenein and unassigned hugocaillard Jul 17, 2024
@smcclellan smcclellan moved this from 📋 Backlog to 🏗 In Progress in DevTools Jul 25, 2024
@smcclellan
Copy link
Contributor

smcclellan commented Jul 25, 2024 •
edited
Loading

Update: This will be started either later this quarter (Q3) or start of next.

@smcclellan smcclellan moved this from 🏗 In Progress to 📋 Backlog in DevTools Aug 1, 2024
@hugocaillard hugocaillard linked a pull request Feb 6, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tippenein tippenein

Labels
None yet
Projects
DevTools
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarinet format hirosystems/clarinet
5 participants
@lgalabru @hugocaillard @tippenein @obycode @smcclellan