fix: preprocess bug to remove network from the dummy transaction

Author: asimm241

package-lock.json

@@ -128,6 +128,7 @@
     "jsonc-parser": "^3.0.0",
     "jsonrpc-lite": "^2.1.0",
     "micro-base58": "^0.5.0",
+    "nock": "^13.1.1",
     "node-fetch": "^2.6.0",
     "node-pg-migrate": "^5.9.0",
     "p-queue": "^6.3.0",

package.json

@@ -208,8 +208,10 @@ export function createRosettaConstructionRouter(db: DataStore, chainId: ChainID)
           functionName: 'stack-stx',
           publicKey: '000000000000000000000000000000000000000000000000000000000000000000',
           functionArgs: [uintCV(options.amount), poxAddressCV, uintCV(0), uintCV(0)],
-          validateWithAbi: true,
+          validateWithAbi: false,
           network: getStacksNetwork(),
+          fee: new BN(0),
+          nonce: new BN(0),
         };
         transaction = await makeUnsignedContractCall(dummyStackingTx);
         break;
@@ -231,8 +233,10 @@ export function createRosettaConstructionRouter(db: DataStore, chainId: ChainID)
             noneCV(),
             noneCV(),
           ],
-          validateWithAbi: true,
+          validateWithAbi: false,
           network: getStacksNetwork(),
+          fee: new BN(0),
+          nonce: new BN(0),
         };
         transaction = await makeUnsignedContractCall(dummyStackingTx);
         break;

src/api/routes/rosetta/construction.ts

@@ -45,13 +45,16 @@ import {
 import { OfflineDummyStore } from '../datastore/offline-dummy-store';
 import { getStacksTestnetNetwork, testnetKeys } from '../api/routes/debug';
 import { getSignature, getStacksNetwork } from '../rosetta-helpers';
+import * as nock from 'nock';
 describe('Rosetta API', () => {
   let db: DataStore;
   let api: ApiServer;
 
   beforeAll(async () => {
     db = OfflineDummyStore;
     api = await startApiServer({ datastore: db, chainId: ChainID.Testnet });
+    nock.disableNetConnect();
+    nock.enableNetConnect('127.0.0.1:3999');
   });
 
   test('Success: offline - network/list', async () => {
@@ -295,11 +298,13 @@ describe('Rosetta API', () => {
     const recipientAddr = 'STDE7Y8HV3RX8VBM2TZVWJTS7ZA1XB0SSC3NEVH0';
     const amount = new BN(1000);
     const fee = new BN(180);
+    const nonce = new BN(0);
     const options: SignedTokenTransferOptions = {
       recipient: recipientAddr,
       amount: amount,
       fee: fee,
       senderKey: testnetKeys[0].secretKey,
+      nonce: nonce,
       network: getStacksTestnetNetwork(),
     };
     const testTransaction = await makeSTXTokenTransfer(options);
@@ -338,10 +343,12 @@ describe('Rosetta API', () => {
     const recipientAddr = 'STDE7Y8HV3RX8VBM2TZVWJTS7ZA1XB0SSC3NEVH0';
     const amount = new BN(1000);
     const fee = new BN(180);
+    const nonce = new BN(0);
     const tokenTransferOptions: UnsignedTokenTransferOptions = {
       recipient: recipientAddr,
       amount: amount,
       fee: fee,
+      nonce: nonce,
       publicKey: publicKey,
       network: getStacksTestnetNetwork(),
     };
@@ -718,5 +725,6 @@ describe('Rosetta API', () => {
 
   afterAll(async () => {
     await api.terminate();
+    nock.enableNetConnect()
   });
 });