Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect units on Namespace price API #1621

Open
bilalanees98 opened this issue Apr 19, 2023 · 3 comments
Open

Incorrect units on Namespace price API #1621

bilalanees98 opened this issue Apr 19, 2023 · 3 comments
Assignees
Labels

Comments

@bilalanees98
Copy link

Describe the bug
The response returned by the API dictates that units=STX, however the actual amount returned is in Micro Stacks.
To Reproduce
Steps to reproduce the behavior:

  1. Hit the API: https://api.mainnet.hiro.so/v2/prices/namespaces/something
  2. Check response

Expected behavior
I think the response should return 'uSTX' as the unit and the documentation should be updated to reflect this.

Screenshots
Screenshot 2023-04-19 at 1 57 02 PM

Additional context
Link to documentation: https://hirosystems.github.io/stacks-blockchain-api/#tag/Names/operation/get_namespace_price

@github-project-automation github-project-automation bot moved this to Recent issues in API Board Apr 19, 2023
@smcclellan
Copy link
Contributor

This would be a big breaking change to complete. It's probably a Won't Fix unless a new endpoint would be better here. Would updating our documentation be helpful for this instead?

@smcclellan smcclellan moved this from Recent issues to Icebox in API Board Apr 20, 2023
@bilalanees98
Copy link
Author

Yes I think that would work as a short-term fix.

@smcclellan smcclellan moved this from Icebox to Backlog in API Board Jul 7, 2023
@sabbyanandan
Copy link

@smcclellan: Feel free to move this over to Docs repo along with the context/guidance on what needs to be updated.

@smcclellan smcclellan removed this from API Board Jul 31, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Hiro Docs Jul 31, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in API Board Sep 19, 2023
@andresgalante andresgalante moved this from 🆕 New to 📋 Backlog in API Board Nov 6, 2023
@ryanwaits ryanwaits added this to Devrel Jul 1, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Devrel Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Status: 🆕 New
Status: 🆕 New
Development

No branches or pull requests

4 participants