Skip to content

Commit f717ae2

Browse files
committed
add void detection
1 parent cabcd4f commit f717ae2

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

src/main/java/org/restdoc/server/impl/RestDocGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ private ResponseDefinition getMethodResponse(final Method method) {
288288
def.header(restDocHeader.name(), restDocHeader.description(), restDocHeader.required());
289289
}
290290
}
291-
if (def.getTypes().isEmpty()) {
291+
if (def.getTypes().isEmpty() && !method.getReturnType().equals(Void.TYPE)) {
292292
final String schema = SchemaResolver.getSchemaFromTypeOrNull(method.getGenericReturnType(), this.schemaMap, this.ext);
293293
String[] mediaTypes = MediaTypeResolver.getProducesMediaType(method);
294294
if (mediaTypes != null) {

src/main/java/org/restdoc/server/impl/util/SchemaResolver.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ public static String getSchemaFromType(final Type type, Map<String, Schema> sche
5757
* @return the schema URI
5858
*/
5959
public static String getSchemaFromTypeOrNull(final Type type, Map<String, Schema> schemaMap, IRestDocGeneratorExtension ext) {
60+
if (type.equals(Void.TYPE)) {
61+
return null;
62+
}
6063
if (type instanceof Class) {
6164
return SchemaResolver.getSchemaFromClassOrNull((Class<?>) type, schemaMap, ext);
6265
}

src/test/java/org/restdoc/server/impl/reflect/ReflectClass.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ public Msg[] rAMsg() {
3838
return null;
3939
}
4040

41+
public void rVoid() {
42+
43+
}
44+
4145
public void pString(String p) {
4246
//
4347
}

src/test/java/org/restdoc/server/impl/reflect/SchemaResolverTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ public void testReturn() {
4141
Assert.assertEquals("string", SchemaResolver.getSchemaFromTypeOrNull(SchemaResolverTest.ret("rString"), this.map, null));
4242
Assert.assertEquals("long", SchemaResolver.getSchemaFromTypeOrNull(SchemaResolverTest.ret("rLong"), this.map, null));
4343
Assert.assertEquals("boolean", SchemaResolver.getSchemaFromTypeOrNull(SchemaResolverTest.ret("rLBoolean"), this.map, null));
44+
Assert.assertEquals(null, SchemaResolver.getSchemaFromTypeOrNull(SchemaResolverTest.ret("rVoid"), this.map, null));
4445
}
4546

4647
@Test

0 commit comments

Comments
 (0)