Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CellProvisioning doesn't match the enum in holochain_types #317

Open
pdaoust opened this issue Jan 3, 2025 · 0 comments · May be fixed by #318
Open

CellProvisioning doesn't match the enum in holochain_types #317

pdaoust opened this issue Jan 3, 2025 · 0 comments · May be fixed by #318
Assignees
@pdaoust
Labels
bug Something isn't working

Comments

@pdaoust
Copy link

pdaoust commented Jan 3, 2025

The CellProvisioning type in src/api/admin/types.ts doesn't closely match that of the corresponding Rust type, in either 0.4 or 0.5. There's a new protected flag for UseExisting; suggest using a tagged union rather than an interface. I'll follow up with a PR today.
@pdaoust pdaoust added the bug Something isn't working label Jan 3, 2025
@pdaoust pdaoust self-assigned this Jan 3, 2025
@pdaoust pdaoust added this to Holochain Jan 3, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Holochain Jan 3, 2025
@pdaoust pdaoust linked a pull request Jan 3, 2025 that will close this issue
Draft
@pdaoust pdaoust moved this from Backlog to In progress in Holochain Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdaoust pdaoust

Labels
bug Something isn't working
Projects
Holochain
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cell provisioning types holochain/holochain-client-js
1 participant
@pdaoust