Make migration specific on version 1

Author: zweckj

homeassistant/components/onedrive/__init__.py

@@ -124,10 +124,10 @@ async def _migrate_backup_files(client: OneDriveClient, backup_folder_id: str) -
     """Migrate backup files to metadata version 2."""
     files = await client.list_drive_items(backup_folder_id)
     for file in files:
-        if file.description and "homeassistant_version" in file.description:
-            metadata = loads(unescape(file.description))
-            if metadata["metadata_version"] != 1:
-                continue
+        if file.description and '"metadata_version": 1' in (
+            metadata_json := unescape(file.description)
+        ):
+            metadata = loads(metadata_json)
             del metadata["metadata_version"]
             metadata_filename = file.name.rsplit(".", 1)[0] + ".metadata.json"
             metadata_file = await client.upload_file(

tests/components/onedrive/test_init.py

@@ -20,6 +20,7 @@ async def test_load_unload_config_entry(
     hass: HomeAssistant,
     mock_config_entry: MockConfigEntry,
     mock_onedrive_client_init: MagicMock,
+    mock_onedrive_client: MagicMock,
 ) -> None:
     """Test loading and unloading the integration."""
     await setup_integration(hass, mock_config_entry)
@@ -28,6 +29,10 @@ async def test_load_unload_config_entry(
     token_callback = mock_onedrive_client_init.call_args[0][0]
     assert await token_callback() == "mock-access-token"
 
+    # make sure metadata migration is not called
+    assert mock_onedrive_client.upload_file.call_count == 0
+    assert mock_onedrive_client.update_drive_item.call_count == 0
+
     assert mock_config_entry.state is ConfigEntryState.LOADED
 
     await hass.config_entries.async_unload(mock_config_entry.entry_id)