Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastAPI migration testing of Mapper's workflow #6725

Open
manjitapandey opened this issue Feb 3, 2025 · 14 comments
Open

FastAPI migration testing of Mapper's workflow #6725

manjitapandey opened this issue Feb 3, 2025 · 14 comments
Labels
status: testing Does it really work or is it pretending to work?

Comments

@manjitapandey
Copy link

manjitapandey commented Feb 3, 2025

Go to the Explore Projects page on Tasking Manager staging site: https://tasks-stage.hotosm.org
Testing the Explore Projects Page:

  • Verify that project cards are displayed across different pages.
  • Confirm that the map next to each project card can be shown or hidden.
  • Apply filters and search for specific projects; confirm that results update as expected.
  • Download project data as a CSV file and confirm it downloads without issues.
  • Open the downloaded csv file and confirm all column are there as expected. You can also compare the behavior with tasking manager live server.

Project Details Page:

  • Click on any project card to open its Project Details page.
  • Check that you can both view and post project-specific questions and comments. Also try tagging contributors and project authors and confirm if notification is received to their end. If permission is enabled, also confirm that respective email is sent to tagged users.
  • Test marking projects as favorites by clicking on ‘mark as favorite’ on the bottom ribbon of the project details page. Also try removing the project from your favorite.
  • Confirm that similar projects and the contribution timeline are visible and accurate.
  • Verify download osm data is functional. Also see if the features expected to be mapped and download list features are same.
  • Click on the Contribute button at the bottom right corner and confirm that it takes you to the project’s Tasks page.

On the Tasks Page:

  • Users should be able to view project’s instructions.
  • Users should be able to view the Contributions on the contribution tab. Try applying the filters of the contribution tab and verify the filtered data is correct.
  • Verify that the status of tasks is visible and accurate when viewed on the map.
  • Confirm that you can access the history in (Activities and comments) of individual tasks. Also verify that you can post comments on the specific task. Also try tagging contributors and confirm if notification is received to their end. If permission is enabled, also confirm that respective email is sent to tagged users.

Mapping a Task:

  • Select a task and click Map selected task. Verify that you are redirected to the iD Editor page as expected. Once on the iD Editor Page, please test the following mapping actions:
  • Attempt to lock the task for mapping.
  • Split the Task: Test splitting the task into smaller segments.
  • Try marking the task as fully mapped with and without adding a comment.
  • Test extending the mapping time for the task. The standard timeout for mapping a task is 12 hours. You can leave the tasks as locked for 12 hours before trying to map the task to achieve this state.
  • Mark the task as invalid (e.g., mark it as bad imagery )
  • Test stopping the mapping process midway clicking on 'select another tasks'.
  • Switch Editors: Change the editor from iD Editor to JOSM and other available editors and switch them back to ID editor.
  • Test if you are able to map the features by setting different permission level like if you are beginner mapper, try mapping project where only intermediate or advanced level users is permitted. And confirm the permission dialog box appears to restrict you from mapping.
  • Test if you are able to map the features by setting different permission level like if you are not member or manager of mapping team with permitted mapping permission. And confirm the permission dialog box appears to restrict you from mapping. Ask team manager to provide you member permission and try mapping the same project, you should be able to map this time. Also ask to upgrade permission to manager of team, and test the mapping workflow.

Viewing the contribution

  • Statistics should be populated on statistics cards. - confirm all the statistics are correct i.e. number of buildings, road mapped, Top 5 countries contributed etc.
  • See contribution timeline and projects touched.
  • See projects contributed by me and also apply filters to see projects created by me, managed by me or my favourite projects.
  • View the list of tasks contributed and also apply filters or search tasks.
  • View the teams in which you are the part of.
@petya-kangalova petya-kangalova added the status: testing Does it really work or is it pretending to work? label Feb 4, 2025
@adiatmad
Copy link

adiatmad commented Feb 6, 2025

  1. I downloaded the CSV from this link, and the author's name appears as the Tasking Manager name, not the OSM username. Is this the expected result?

Download project data as a CSV file and confirm it downloads without issues


  1. I’m not receiving notifications after tagging #contributors, #managers, or #author. Also, the # symbol applies bold styling in TM format.

Check that you can both view and post project-specific questions ....

Image
  1. I don't see my top 5 countries, timeline, project touched on MyStats page. I am using Firefox and Edge browser.

Image

@manjitapandey
Copy link
Author

  1. This behavior seems to be expected because I can reproduce same behavior on current prod too. Looping @ramyaragupathy to confirm.
  2. I can reproduce this issue. will update you once fixed.
  3. I am not being able to reproduce it. Can you may be provide more info on it or see anything is failing on network panel?

@adiatmad
Copy link

adiatmad commented Feb 6, 2025

@manjitapandey
3. I accessed this page but still don’t see the mentioned items. Here is my network panel.
Image

@manjitapandey
Copy link
Author

manjitapandey commented Feb 6, 2025

I’m not receiving notifications after tagging #contributors, #managers, or #author. Also, the # symbol applies bold styling in TM format.

This issue seems to be rather with current production too and not only on FastAPI incorporated staging server. The issue is already created regarding this, you can follow up on #6590 for more info.

I don't see my top 5 countries, timeline, project touched on MyStats page. I am using Firefox and Edge browser.

This has been fixed. Can you verify it from your side?

@adiatmad
Copy link

adiatmad commented Feb 6, 2025

@manjitapandey Thank you for filing that. I’ve subscribed to stay updated.

Also, I can confirm that I can now see my stats. Thanks!
Image

@martien-176
Copy link

https://tasks-stage.hotosm.org/projects/15973/tasks/?search=415

A mapper flagged me here with a question. I am not sure why they asked me that specific question on the staging server, it does not seem to be referring to testing. Maybe they were confused somehow, will have to ask the mapper later.

Issue i want to report is that this task is still flagged as locked, although opened 2 days ago. See screenshot.

Image

@martien-176
Copy link

I retested the locked-task-timeout issue: this time the task was unlocked eventually.

Although i only checked the task after 16 hours.

@manjitapandey do i have this test further, eg check after 2 hours?

@Pseudorandom-Pseudonym
Copy link

Mapping a Task:

@Pseudorandom-Pseudonym
Copy link

@manjitapandey Hi I see that the vast majority of my stats have correctly transftered to the staging site, however there are discrepancies between the contribution timeline and tasks data. Could you please investigate the casue?

Image
Fig.1. User Stats Tasks Show you Mapped Validated and Needed More Mapping Discrepancies Between Production and Staging Site (Staging left, production right)

Image
Fig.2. Production Site User Contribution Timeline

Image
Fig.3. Staging Site User Contribution Timeline

In places the staging site timeline appears to be translated but for example in the right most cluster there simply appear to be fewer squares. I can confirm that they are not just really light and difficult to see; when I hover my cursor over them it states no contributions.

@manjitapandey
Copy link
Author

On some occasions writing comments with the managers hashtag will prevent you from taking certain actions like submitting, or selecting another task.

Thanks for reporting @Pseudorandom-Pseudonym , We are looking to fixing it and update you soon. Also we usually expect FastAPI issues report on a comment. You need not create a separate issue since it may confuse some users.

@manjitapandey
Copy link
Author

Hi I see that the vast majority of my stats have correctly transfered to the staging site, however there are discrepancies between the contribution timeline and tasks data. Could you please investigate the cause?

Hi @Pseudorandom-Pseudonym , Its little complicated workflow that caused this behavior but I can assure you its the expected behavior.
We pulled all the data, projects and contributions from tasking manager on January so the stats until then were same and after that its different because you contributed on both servers in different way. On contribution timeline it seems like you contributed on production more than on staging hence contribution updated respectively.

@manjitapandey
Copy link
Author

On some occasions writing comments with the managers hashtag will prevent you from taking certain actions like submitting, or selecting another task.

This is fixed now. Please confirm it from your side. We can close the issue for now.

@Pseudorandom-Pseudonym
Copy link

On some occasions writing comments with the managers hashtag will prevent you from taking certain actions like submitting, or selecting another task.

This is fixed now. Please confirm it from your side. We can close the issue for now.

I confirm that this issue is no longer occuring for me. I recieve no error and am able to submit tasks, comments and select another task without issue. Thank you!

The original idea I had was to change the error message text to something more specific like "there are no managers selected for this project" (if that's the reason for the error) to let users know that the hashtag would be ineffective, however, I have more recently had the Idea that it would be better to simply not show hashtags which would not notify anyone. e.g. if no managers are assigned to a project do not show the hashtag as in such cases an irrelevant hashtag can delay project communication.

@martien-176
Copy link

I tested all items: all are okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing Does it really work or is it pretending to work?
Projects
None yet
Development

No branches or pull requests

5 participants