Tidy all code with the latest Perl::Tidy

Author: autarch

bin/tidyall

@@ -152,7 +152,7 @@ else {
 }
 
 my @results = $ct->process_paths(@paths);
-my $status = ( grep { $_->error } @results ) ? 1 : 0;
+my $status  = ( grep { $_->error } @results ) ? 1 : 0;
 exit($status);
 
 sub handle_pipe {
@@ -162,7 +162,7 @@ sub handle_pipe {
     $params{$_} = 0 for ('verbose');
 
     $conf_file ||= $tidyall_class->find_conf_file( \@conf_names, $pipe_filename->parent );
-    my $ct = $tidyall_class->new_from_conf_file( $conf_file, %params );
+    my $ct     = $tidyall_class->new_from_conf_file( $conf_file, %params );
     my $source = do { local $/; <STDIN> };
 
     # Merge stdout and stderr and output all to stderr, so that stdout is

lib/Code/TidyAll.pm

@@ -214,7 +214,7 @@ sub _build_backup_ttl_secs {
 }
 
 sub _build_base_sig {
-    my $self = shift;
+    my $self           = shift;
     my $active_plugins = join( q{|}, map { $_->name } @{ $self->_plugin_objects } );
     return $self->_sig( [ $Code::TidyAll::VERSION || 0, $active_plugins ] );
 }
@@ -238,7 +238,7 @@ sub _build_plugins_to_run {
     my $self = shift;
 
     my $all_plugins = $self->plugins;
-    my %selected = map { $_ => 1 } @{ $self->selected_plugins };
+    my %selected    = map { $_ => 1 } @{ $self->selected_plugins };
     my %plugins;
 
     if (%selected) {
@@ -565,7 +565,7 @@ sub process_file {
     }
 
     my $contents = $cache_model->file_contents || $full_path->slurp;
-    my $result = $self->process_source( $contents, $path );
+    my $result   = $self->process_source( $contents, $path );
 
     if ( $result->state eq 'tidied' ) {
 

lib/Code/TidyAll/Git/Prereceive.pm

@@ -116,7 +116,7 @@ sub check_input {
 sub create_tidyall {
     my ( $self, $commit ) = @_;
 
-    my $temp_dir = tempdir_simple();
+    my $temp_dir   = tempdir_simple();
     my @conf_names = $self->conf_name ? ( $self->conf_name ) : Code::TidyAll->default_conf_names;
     my ($conf_file) = grep { $self->get_file_contents( $_, $commit ) } @conf_names
         or die sprintf( 'could not find conf file %s', join( ' or ', @conf_names ) );
@@ -140,7 +140,7 @@ sub create_tidyall {
 sub get_changed_files {
     my ( $self, $base, $commit ) = @_;
     my $output = capturex( $self->git_path, 'diff', '--numstat', '--name-only', "$base..$commit" );
-    my @files = grep {/\S/} split( "\n", $output );
+    my @files  = grep {/\S/} split( "\n", $output );
     return @files;
 }
 

lib/Code/TidyAll/Role/RunsCommand.pm

@@ -36,7 +36,7 @@ sub _run_or_die {
             my $signal = $? & 127;
             my $msg    = "exited with $code";
             $msg .= " - received signal $signal" if $signal;
-            $msg .= " - output was:\n$output" if defined $output and length $output;
+            $msg .= " - output was:\n$output"    if defined $output and length $output;
             die "$msg\n";
         }
     }

lib/Code/TidyAll/SVN/Precommit.pm

@@ -63,7 +63,7 @@ sub check {
         my %conf_files;
         foreach my $file (@files) {
             if ( my $conf_file = $self->find_conf_for_file($file) ) {
-                my $root = $conf_file->parent;
+                my $root     = $conf_file->parent;
                 my $rel_file = substr( $file, length($root) + 1 );
                 $conf_files{$conf_file}->{$rel_file}++;
             }

lib/Code/TidyAll/SVN/Util.pm

@@ -17,7 +17,7 @@ sub svn_uncommitted_files {
 
     $dir = realpath($dir);
     my $output = capturex( 'svn', 'status', $dir );
-    my @lines = grep {/^[AM]/} split( "\n", $output );
+    my @lines  = grep {/^[AM]/} split( "\n", $output );
     my (@files) = grep {-f} ( $output =~ m{^[AM]\s+(.*)$}gm );
     return @files;
 }

t/lib/TestFor/Code/TidyAll/Basic.pm

@@ -108,7 +108,7 @@ sub test_filemode : Tests {
     }
 
     my $root_dir = $self->create_dir( { 'foo.txt' => 'abc' } );
-    my $file = $root_dir->child('foo.txt');
+    my $file     = $root_dir->child('foo.txt');
     $file->chmod('0755');
     my $ct = Code::TidyAll->new(
         plugins  => { test_plugin('UpperText') => { select => '**/foo*' } },
@@ -147,7 +147,7 @@ sub test_plugin_order_and_atomicity : Tests {
             # note without the weight here this would run first, and the
             # letters in the photetic words themselves would be reversed
             test_plugin('AlwaysPhonetic') => { select => '**/*.txt', weight => 51 }
-            )
+        )
     } ( 1 .. 3 );
 
     $self->tidy(
@@ -176,7 +176,7 @@ sub test_quiet_and_verbose : Tests {
     foreach my $state ( 'normal', 'quiet', 'verbose' ) {
         foreach my $error ( 0, 1 ) {
             my $root_dir = $self->create_dir( { 'foo.txt' => ( $error ? '123' : 'abc' ) } );
-            my $output = capture_stdout {
+            my $output   = capture_stdout {
                 my $ct = Code::TidyAll->new(
                     plugins  => {%UpperText},
                     root_dir => $root_dir,
@@ -235,7 +235,7 @@ sub test_caching_and_backups : Tests {
                     my $desc
                         = "(no_cache=$no_cache, no_backups=$no_backups, model=$cache_model_class, cache_class=$chi)";
                     my $root_dir = $self->create_dir( { 'foo.txt' => 'abc' } );
-                    my $ct = Code::TidyAll->new(
+                    my $ct       = Code::TidyAll->new(
                         plugins           => {%UpperText},
                         root_dir          => $root_dir,
                         cache_model_class => $cache_model_class,
@@ -245,7 +245,7 @@ sub test_caching_and_backups : Tests {
                     );
                     my $output;
                     my $file = path( $root_dir, 'foo.txt' );
-                    my $go = sub {
+                    my $go   = sub {
                         $output = capture_stdout { $ct->process_paths($file) };
                     };
 
@@ -314,7 +314,7 @@ sub test_selects_and_ignores : Tests {
 
     my @files = ( 'a/foo.pl', 'b/foo.pl', 'a/foo.pm', 'a/bar.pm', 'b/bar.pm' );
     my $root_dir = $self->create_dir( { map { $_ => 'hi' } @files } );
-    my $ct = Code::TidyAll->new(
+    my $ct       = Code::TidyAll->new(
         root_dir => $root_dir,
         plugins  => {
             test_plugin('UpperText') => {
@@ -453,7 +453,7 @@ sub test_errors : Tests {
     }
     qr/unknown options/;
 
-    my $ct = Code::TidyAll->new( plugins => {%UpperText}, root_dir => $root_dir );
+    my $ct     = Code::TidyAll->new( plugins => {%UpperText}, root_dir => $root_dir );
     my $output = capture_stdout { $ct->process_paths("$root_dir/baz/blargh.txt") };
     like( $output, qr/baz\/blargh.txt: not a file or directory/, 'file not found' );
 

t/lib/TestFor/Code/TidyAll/Git.pm

@@ -75,7 +75,7 @@ sub test_git : Tests {
     };
 
     my $prereceive_hook_file = $shared_dir->child(qw( hooks pre-receive ));
-    my $prereceive_hook = sprintf( $prereceive_hook_template, $self->_lib_dirs );
+    my $prereceive_hook      = sprintf( $prereceive_hook_template, $self->_lib_dirs );
     $prereceive_hook_file->spew($prereceive_hook);
     $prereceive_hook_file->chmod(0775);
 
@@ -299,7 +299,7 @@ sub _make_working_dir_and_repo {
     runx(qw( git commit -q -m added tidyall.ini .gitignore ));
 
     my $precommit_hook_file = $hooks_dir->child('pre-commit');
-    my $precommit_hook = sprintf( $precommit_hook_template, $self->_lib_dirs );
+    my $precommit_hook      = sprintf( $precommit_hook_template, $self->_lib_dirs );
     $precommit_hook_file->spew($precommit_hook);
     $precommit_hook_file->chmod(0755);
 

t/lib/TestFor/Code/TidyAll/SVN.pm

@@ -57,7 +57,7 @@ sub test_svn : Tests {
     cmp_deeply( [ svn_uncommitted_files($work_dir) ], [], 'no uncommitted files' );
 
     my $precommit_hook_file = $hooks_dir->child('pre-commit');
-    my $precommit_hook = sprintf( $precommit_hook_template, path('lib')->realpath, $hook_log );
+    my $precommit_hook      = sprintf( $precommit_hook_template, path('lib')->realpath, $hook_log );
     $precommit_hook_file->spew($precommit_hook);
     $precommit_hook_file->chmod(0755);
 

t/lib/TestHelper/Test/Class.pm

@@ -43,14 +43,14 @@ sub tidy {
     my $root_dir = $self->create_dir( $params{source} );
 
     my $options = $params{options} || {};
-    my $ct = Code::TidyAll->new(
+    my $ct      = Code::TidyAll->new(
         plugins  => $params{plugins},
         root_dir => $root_dir,
         %$options
     );
 
     my @results;
-    my $output = capture_stdout { @results = $ct->process_all() };
+    my $output      = capture_stdout { @results = $ct->process_all() };
     my $error_count = grep { $_->error } @results;
     if ( $params{errors} ) {
         ok( $error_count > 0, "$desc - error_count > 0" );