fix(scripts/lint): resolve ESLint plugins relative to @hover/javascript installation

This makes the ESLint configuration handle cases where package managers nest the
ESLint dependencies in node_modules/@hover/javascript/node_modules

Author: jrolfs

src/run-script.js

@@ -18,6 +18,7 @@ if (script) {
       s
         .replace(scriptsPath, '')
         .replace(/__tests__/, '')
+        .replace(/__mocks__/, '')
         .replace(/\.js$/, ''),
     )
     .filter(Boolean)

src/scripts/__tests__/__snapshots__/lint.js.snap

@@ -1,19 +1,19 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`lint --no-cache will disable caching 1`] = `eslint --config ./src/config/eslintrc.js --ignore-path ./src/config/eslintignore --ext .js,.jsx,.ts,.tsx --no-cache .`;
+exports[`lint --no-cache will disable caching 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --config ./src/config/eslintrc.js --ignore-path ./src/config/eslintignore --ext .js,.jsx,.ts,.tsx --no-cache .`;
 
-exports[`lint calls eslint CLI with default args 1`] = `eslint --config ./src/config/eslintrc.js --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
+exports[`lint calls eslint CLI with default args 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --config ./src/config/eslintrc.js --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
 
-exports[`lint does not use built-in config with .eslintrc file 1`] = `eslint --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
+exports[`lint does not use built-in config with .eslintrc file 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
 
-exports[`lint does not use built-in config with .eslintrc.js file 1`] = `eslint --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
+exports[`lint does not use built-in config with .eslintrc.js file 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
 
-exports[`lint does not use built-in config with --config 1`] = `eslint --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx --config ./custom-config.js .`;
+exports[`lint does not use built-in config with --config 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx --config ./custom-config.js .`;
 
-exports[`lint does not use built-in config with eslintConfig pkg prop 1`] = `eslint --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
+exports[`lint does not use built-in config with eslintConfig pkg prop 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --ignore-path ./src/config/eslintignore --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
 
-exports[`lint does not use built-in ignore with .eslintignore file 1`] = `eslint --config ./src/config/eslintrc.js --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
+exports[`lint does not use built-in ignore with .eslintignore file 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --config ./src/config/eslintrc.js --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
 
-exports[`lint does not use built-in ignore with --ignore-path 1`] = `eslint --config ./src/config/eslintrc.js --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx --ignore-path ./my-ignore .`;
+exports[`lint does not use built-in ignore with --ignore-path 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --config ./src/config/eslintrc.js --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx --ignore-path ./my-ignore .`;
 
-exports[`lint does not use built-in ignore with eslintIgnore pkg prop 1`] = `eslint --config ./src/config/eslintrc.js --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;
+exports[`lint does not use built-in ignore with eslintIgnore pkg prop 1`] = `eslint --resolve-plugins-relative-to <PROJECT_ROOT>/src/scripts/__mocks__/@hover/javascript --config ./src/config/eslintrc.js --cache --cache-location <PROJECT_ROOT>/node_modules/.cache/.eslintcache --ext .js,.jsx,.ts,.tsx .`;

src/scripts/lint.js

@@ -15,6 +15,18 @@ const useBuiltinConfig =
   !hasFile('.eslintrc.json') &&
   !hasPkgProp('eslintConfig')
 
+let resolved
+
+try {
+  resolved = require.resolve('@hover/javascript/eslint')
+} catch {
+  // This is only here for internal usage as the above will not resolve
+}
+
+const resolvePlugins = resolved
+  ? ['--resolve-plugins-relative-to', path.dirname(resolved)]
+  : []
+
 const config = useBuiltinConfig
   ? ['--config', hereRelative('../config/eslintrc.js')]
   : []
@@ -44,7 +56,15 @@ const filesToApply = filesGiven ? [] : ['.']
 
 const result = spawn.sync(
   resolveBin('eslint'),
-  [...config, ...ignore, ...cache, ...extensions, ...args, ...filesToApply],
+  [
+    ...resolvePlugins,
+    ...config,
+    ...ignore,
+    ...cache,
+    ...extensions,
+    ...args,
+    ...filesToApply,
+  ],
   {stdio: 'inherit'},
 )