Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TwilioVoice.disconnect() does not play disconnect tone #112

Closed
gentleShark opened this issue Feb 2, 2019 · 3 comments
Closed

TwilioVoice.disconnect() does not play disconnect tone #112

gentleShark opened this issue Feb 2, 2019 · 3 comments

Comments

@gentleShark
Copy link

On Android (and possibly iOS also though I haven't tested) TwilioVoice.disconnect() successfully terminates the call play but does not play an audio tone to convey to the user that the call has been terminated.
@gentleShark
Copy link
Author

the twilio java quickstart implements this by playing disconnect.wav in the raw resources directory but I didn't have much luck importing that file, modifying SoundPoolManager.java considerably, and modifying the TwilioVoiceManager.java disconnect function. my react native app still works but no dissconnect.wav sound

@gentleShark
Copy link
Author

I just created a pull request for this issue: #113

@jdegger
Copy link
Collaborator

jdegger commented Oct 27, 2020

I will be closing this issue so we can continue the discussion on #133

@jdegger jdegger closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gentleShark @jdegger