Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add ability to set the caller display name #139

Closed
lonnylot opened this issue Dec 29, 2019 · 2 comments
Closed

[Feature] Add ability to set the caller display name #139

lonnylot opened this issue Dec 29, 2019 · 2 comments
Labels
enhancement status: in progress

Comments

@lonnylot
Copy link
Contributor

By default we set the display name to the phone number. I propose we modify the TwilioVoice.connect method to accept a contactIdentifier string similar to https://github.com/react-native-webrtc/react-native-callkeep#startcall and add a new method to update active call invites similar to https://github.com/react-native-webrtc/react-native-callkeep#updatedisplay.
@lonnylot lonnylot mentioned this issue Dec 29, 2019
Closed
@jdegger
Copy link
Collaborator

jdegger commented Oct 27, 2020

We're now looking into CallKeep and if we should implement it.

Read our update here #158

@jdegger jdegger mentioned this issue Oct 27, 2020
Closed
@jdegger
Copy link
Collaborator

jdegger commented Dec 10, 2020

This issue is partly resolved. This PR works for incoming calls: #170

@lonnylot lonnylot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement status: in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lonnylot @fabriziomoscon @jdegger