HPCC-33350 Roxie fieldTranslationEnabled not always correct if set in package

Signed-off-by: M Kelly <[email protected]>

Author: mckellyln

common/pkgfiles/pkgimpl.hpp

@@ -124,7 +124,12 @@ class PKGFILES_API CPackageNode : implements IHpccPackage, public CInterface
         const char *val = queryEnv("control:enableFieldTranslation");
         if (!val) val = queryEnv("enableFieldTranslation"); // Backward compatibility
         if (val)
+        {
+            // if val is empty or "true" use global default
+            if (isEmptyString(val) || strToBool(val))
+                return getSysFieldTranslationEnabled();
             return getTranslationMode(val, false);
+        }
         else
             return getSysFieldTranslationEnabled();
     }