Merge pull request #19580 from jeclrsg/hpcc-33573-remove-def-file-references

HPCC-33573 ECL Watch remove DFUDefFile requests for DEF format

Author: GordonSmith

esp/src/eclwatch/LFDetailsWidget.js

@@ -71,7 +71,6 @@ define([
         contentWidget: null,
         dataPatternsWidget: null,
         sourceWidget: null,
-        defWidget: null,
         xmlWidget: null,
         filePartsWidget: null,
         queriesWidget: null,
@@ -95,7 +94,6 @@ define([
             this.contentWidget = registry.byId(this.id + "_Content");
             this.dataPatternsWidget = registry.byId(this.id + "_DataPatterns");
             this.sourceWidget = registry.byId(this.id + "_Source");
-            this.defWidget = registry.byId(this.id + "_DEF");
             this.xmlWidget = registry.byId(this.id + "_XML");
             this.filePartsWidget = registry.byId(this.id + "_FileParts");
             this.queriesWidget = registry.byId(this.id + "_Queries");
@@ -306,13 +304,6 @@ define([
                     this.sourceWidget.init({
                         ECL: this.logicalFile.Ecl
                     });
-                } else if (currSel.id === this.defWidget.id) {
-                    var context = this;
-                    this.logicalFile.fetchDEF(function (response) {
-                        context.defWidget.init({
-                            ECL: response
-                        });
-                    });
                 } else if (currSel.id === this.xmlWidget.id) {
                     var context = this;
                     this.logicalFile.fetchXML(function (response) {
@@ -403,7 +394,6 @@ define([
                 }
                 this.contentWidget.reset();
                 this.sourceWidget.reset();
-                this.defWidget.reset();
                 this.xmlWidget.reset();
                 this.filePartsWidget.reset();
                 this.widget._Queries.reset();

esp/src/eclwatch/templates/LFDetailsWidget.html

@@ -246,8 +246,6 @@ <h2>
             </div>
             <div id="${id}_Source" title="${i18n.ECL}" data-dojo-props="delayWidget: 'ECLSourceWidget', disabled: true" data-dojo-type="DelayLoadWidget">
             </div>
-            <div id="${id}_DEF" title="${i18n.DEF}" data-dojo-props="delayWidget: 'ECLSourceWidget', disabled: true" data-dojo-type="DelayLoadWidget">
-            </div>
             <div id="${id}_XML" title="${i18n.XML}" data-dojo-props="delayProps: {WUXml: true}, delayWidget: 'ECLSourceWidget', disabled: true" data-dojo-type="DelayLoadWidget">
             </div>
             <div id="${id}_FileBelongs" title="${i18n.Superfiles}" data-dojo-props="delayWidget: 'FileBelongsToWidget', disabled: true" data-dojo-type="DelayLoadWidget">

esp/src/src-react/components/FileDetails.tsx

@@ -48,7 +48,6 @@ export const FileDetails: React.FunctionComponent<FileDetailsProps> = ({
             replaceUrl(`/files/${file.NodeGroup}/${logicalFile}`);
         }
     }, [cluster, file?.NodeGroup, file?.isSuperfile, logicalFile]);
-    const [defFile] = useDefFile(cluster, logicalFile, WsDfu.DFUDefFileFormat.def);
     const [xmlFile] = useDefFile(cluster, logicalFile, WsDfu.DFUDefFileFormat.xml);
 
     const onTabSelect = React.useCallback((tab: TabInfo) => {
@@ -69,9 +68,6 @@ export const FileDetails: React.FunctionComponent<FileDetailsProps> = ({
         }, {
             id: "ecl",
             label: nlsHPCC.ECL,
-        }, {
-            id: "def",
-            label: nlsHPCC.DEF,
         }, {
             id: "xml",
             label: nlsHPCC.XML,
@@ -130,9 +126,6 @@ export const FileDetails: React.FunctionComponent<FileDetailsProps> = ({
                 <DelayLoadedPanel visible={tab === "ecl"} size={size}>
                     <SourceEditor text={file?.Ecl} mode="ecl" readonly={true} />
                 </DelayLoadedPanel>
-                <DelayLoadedPanel visible={tab === "def"} size={size}>
-                    <XMLSourceEditor text={defFile} readonly={true} />
-                </DelayLoadedPanel>
                 <DelayLoadedPanel visible={tab === "xml"} size={size}>
                     <XMLSourceEditor text={xmlFile} readonly={true} />
                 </DelayLoadedPanel>