Merge pull request #19544 from streeterd/HPCC-33475_Return_nullptr_instead_of_zero_for_pointer_function_reserveTruncate

HPCC-33475 Return nullptr for empty buffer

Reviewed-by: Jake Smith <[email protected]>
Merged-by: Gavin Halliday <[email protected]>

Author: ghalliday

system/jlib/jbuff.cpp

@@ -354,8 +354,11 @@ void * MemoryBuffer::reserveTruncate(unsigned size)
     unsigned newLen = checkMemoryBufferOverflow(curLen, size);
     curLen += size;
     _reallocExact(newLen);
-    truncate();
-    return buffer + curLen - size;
+    truncate(); // can set buffer to null.
+    if (buffer)
+        return buffer + curLen - size;
+    else
+        return nullptr;
 }
 
 void MemoryBuffer::truncate()