Change priority order for getting node IPs

Internal IP being the first.

Author: kokhang

README.md

@@ -25,7 +25,7 @@ Service-loadbalancer support for L4 is very limited. The binding-port needs to b
 
 ### Software Loadbalancer using keepalived and nginx
 
-1. First we need to create the loadbalancer controller.
+1. First we need to create the loadbalancer controller. Make sure you provide the VIP allocation range. They must be reachable from outside. (Usually they are VIPs on the same subnet as the node network.)
   ```
   $ kubectl create -f examples/kube-loadbalancer-rc.yaml
   ```

loadbalancer-daemon/controllers/controller.go

@@ -232,7 +232,7 @@ func getNodeInterface(kubeClient *client.Client) string {
 	}
 	iface := interfaceByIP(*nodeIP)
 	if iface == "" {
-		glog.Fatalf("Cannot find interface for IP: %v", nodeIP)
+		glog.Fatalf("Cannot find interface for IP: %v", *nodeIP)
 	}
 	return iface
 }

loadbalancer/utils/utils.go

@@ -127,24 +127,26 @@ func MapKeys(m map[string]string) []string {
 }
 
 // GetNodeHostIP returns the provided node's IP, based on the priority:
-// 1. NodeExternalIP
+// 1. NodeInternalIP
 // 2. NodeLegacyHostIP
-// 3. NodeInternalIP
+// 3. NodeExternalIP
+
 func GetNodeHostIP(node api.Node) (*string, error) {
 	addresses := node.Status.Addresses
 	addressMap := make(map[api.NodeAddressType][]api.NodeAddress)
 	for i := range addresses {
 		addressMap[addresses[i].Type] = append(addressMap[addresses[i].Type], addresses[i])
 	}
-	if addresses, ok := addressMap[api.NodeExternalIP]; ok {
+	if addresses, ok := addressMap[api.NodeInternalIP]; ok {
 		return &addresses[0].Address, nil
 	}
 	if addresses, ok := addressMap[api.NodeLegacyHostIP]; ok {
 		return &addresses[0].Address, nil
 	}
-	if addresses, ok := addressMap[api.NodeInternalIP]; ok {
+	if addresses, ok := addressMap[api.NodeExternalIP]; ok {
 		return &addresses[0].Address, nil
 	}
+
 	return nil, fmt.Errorf("Host IP unknown; known addresses: %v", addresses)
 }