performance optimization

Author: andot

io/string_decoder.go

@@ -6,7 +6,7 @@
 |                                                          |
 | io/string_decoder.go                                     |
 |                                                          |
-| LastModified: Jun 5, 2021                                |
+| LastModified: Feb 14, 2022                               |
 | Author: Ma Bingyao <[email protected]>                    |
 |                                                          |
 \*________________________________________________________*/
@@ -85,7 +85,10 @@ func (dec *Decoder) readStringAsBytes(utf16Length int) (data []byte, safe bool)
 			data = append(data, buf[:off]...)
 			return
 		}
-		safe = true
+		if !safe {
+			safe = true
+			data = make([]byte, 0, utf16Length*3)
+		}
 		data = append(data, buf...)
 		if !dec.loadMore() {
 			if remains < 0 {
@@ -106,7 +109,9 @@ func (dec *Decoder) readStringAsSafeBytes(utf16Length int) []byte {
 	if safe {
 		return data
 	}
-	return append(([]byte)(nil), data...)
+	result := make([]byte, len(data))
+	copy(result, data)
+	return result
 }
 
 // ReadStringAsBytes reads string as bytes.
@@ -125,11 +130,14 @@ func (dec *Decoder) readUnsafeString(utf16Length int) (s string) {
 }
 
 func (dec *Decoder) readSafeString(utf16Length int) (s string) {
-	data := dec.readStringAsSafeBytes(utf16Length)
+	data, safe := dec.readStringAsBytes(utf16Length)
 	if data == nil {
 		return
 	}
-	return unsafeString(data)
+	if safe {
+		return unsafeString(data)
+	}
+	return string(data)
 }
 
 // ReadUnsafeString reads unsafe string.
@@ -148,7 +156,7 @@ func (dec *Decoder) ReadSafeString() (s string) {
 
 // ReadString reads safe string and add reference.
 func (dec *Decoder) ReadString() (s string) {
-	s = dec.ReadSafeString()
+	s = dec.ReadUnsafeString()
 	dec.AddReference(s)
 	return
 }

io/string_decoder_test.go

@@ -6,7 +6,7 @@
 |                                                          |
 | io/string_decoder_test.go                                |
 |                                                          |
-| LastModified: May 14, 2021                               |
+| LastModified: Feb 14, 2022                               |
 | Author: Ma Bingyao <[email protected]>                    |
 |                                                          |
 \*________________________________________________________*/
@@ -177,3 +177,47 @@ func TestDecodeStringFromReader(t *testing.T) {
 	dec.Decode(&s)
 	assert.Equal(t, "👩‍👩‍👧‍👧", *s)
 }
+
+func TestLongStringDecode(t *testing.T) {
+	sb := new(strings.Builder)
+	for i := 0; i < 100000; i++ {
+		sb.WriteString("测试")
+		sb.WriteString(strconv.Itoa(i))
+	}
+	src := sb.String()
+	sb = new(strings.Builder)
+	enc := NewEncoder(sb)
+	enc.Encode(src)
+	enc.Encode(src)
+	enc.Encode(src)
+	dec := NewDecoderFromReader(bytes.NewReader(([]byte)(sb.String())), 512)
+	var s *string
+	dec.Decode(&s)
+	assert.Equal(t, src, *s)
+	dec.Decode(&s)
+	assert.Equal(t, src, *s)
+	dec.Decode(&s)
+	assert.Equal(t, src, *s)
+}
+
+func BenchmarkLongStringDecode(b *testing.B) {
+	sb := new(strings.Builder)
+	for i := 0; i < 100000; i++ {
+		sb.WriteString("测试")
+		sb.WriteString(strconv.Itoa(i))
+	}
+	src := sb.String()
+	sb = new(strings.Builder)
+	enc := NewEncoder(sb)
+	enc.Encode(src)
+	enc.Encode(src)
+	enc.Encode(src)
+	b.ResetTimer()
+	for i := 0; i < b.N; i++ {
+		dec := NewDecoderFromReader(bytes.NewReader(([]byte)(sb.String())), 512)
+		var s *string
+		dec.Decode(&s)
+		dec.Decode(&s)
+		dec.Decode(&s)
+	}
+}

rpc/codec/jsonrpc/client_codec.go

@@ -6,7 +6,7 @@
 |                                                          |
 | rpc/codec/jsonrpc/client_codec.go                        |
 |                                                          |
-| LastModified: Aug 24, 2021                               |
+| LastModified: Feb 14, 2022                               |
 | Author: Ma Bingyao <[email protected]>                    |
 |                                                          |
 \*________________________________________________________*/
@@ -60,9 +60,11 @@ func (c *ClientCodec) Decode(response []byte, context *core.ClientContext) (resu
 			if err = c.Codec.Unmarshal(data, p); err != nil {
 				return
 			}
-			result = append(result, t.Indirect(p))
+			result = []interface{}{t.Indirect(p)}
 		default:
-			for i, r := range resp.Result.([]interface{}) {
+			res := resp.Result.([]interface{})
+			result = make([]interface{}, 0, len(res))
+			for i, r := range res {
 				data, _ := c.Codec.Marshal(r)
 				t := reflect2.Type2(context.ReturnType[i])
 				p := t.New()

rpc/plugins/reverse/provider.go

@@ -6,7 +6,7 @@
 |                                                          |
 | rpc/plugins/reverse/provider.go                          |
 |                                                          |
-| LastModified: May 19, 2021                               |
+| LastModified: Feb 14, 2022                               |
 | Author: Ma Bingyao <[email protected]>                    |
 |                                                          |
 \*________________________________________________________*/
@@ -150,8 +150,9 @@ func (p *Provider) Execute(ctx context.Context, name string, args []interface{})
 		out = out[:n-1]
 		n--
 	}
+	result = make([]interface{}, n)
 	for i := 0; i < n; i++ {
-		result = append(result, out[i].Interface())
+		result[i] = out[i].Interface()
 	}
 	return
 }