Skip to content

Commit 187d2d8

Browse files
committed
Moving the rest of runc to x/sys/unix
Signed-off-by: Christy Perez <[email protected]>
1 parent 3d7cb42 commit 187d2d8

File tree

4 files changed

+46
-40
lines changed

4 files changed

+46
-40
lines changed

checkpoint.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@ import (
66
"fmt"
77
"strconv"
88
"strings"
9-
"syscall"
109

1110
"github.com/opencontainers/runc/libcontainer"
1211
"github.com/opencontainers/runtime-spec/specs-go"
1312
"github.com/urfave/cli"
13+
14+
"golang.org/x/sys/unix"
1415
)
1516

1617
var checkpointCommand = cli.Command{
@@ -113,7 +114,7 @@ func setManageCgroupsMode(context *cli.Context, options *libcontainer.CriuOpts)
113114
}
114115

115116
var namespaceMapping = map[specs.LinuxNamespaceType]int{
116-
specs.NetworkNamespace: syscall.CLONE_NEWNET,
117+
specs.NetworkNamespace: unix.CLONE_NEWNET,
117118
}
118119

119120
func setEmptyNsMask(context *cli.Context, options *libcontainer.CriuOpts) error {

delete.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ import (
1111

1212
"github.com/opencontainers/runc/libcontainer"
1313
"github.com/urfave/cli"
14+
15+
"golang.org/x/sys/unix"
1416
)
1517

1618
func killContainer(container libcontainer.Container) error {
17-
_ = container.Signal(syscall.SIGKILL, false)
19+
_ = container.Signal(unix.SIGKILL, false)
1820
for i := 0; i < 100; i++ {
1921
time.Sleep(100 * time.Millisecond)
2022
if err := container.Signal(syscall.Signal(0), false); err != nil {

kill.go

+37-35
Original file line numberDiff line numberDiff line change
@@ -8,45 +8,47 @@ import (
88
"strings"
99
"syscall"
1010

11+
"golang.org/x/sys/unix"
12+
1113
"github.com/urfave/cli"
1214
)
1315

1416
var signalMap = map[string]syscall.Signal{
15-
"ABRT": syscall.SIGABRT,
16-
"ALRM": syscall.SIGALRM,
17-
"BUS": syscall.SIGBUS,
18-
"CHLD": syscall.SIGCHLD,
19-
"CLD": syscall.SIGCLD,
20-
"CONT": syscall.SIGCONT,
21-
"FPE": syscall.SIGFPE,
22-
"HUP": syscall.SIGHUP,
23-
"ILL": syscall.SIGILL,
24-
"INT": syscall.SIGINT,
25-
"IO": syscall.SIGIO,
26-
"IOT": syscall.SIGIOT,
27-
"KILL": syscall.SIGKILL,
28-
"PIPE": syscall.SIGPIPE,
29-
"POLL": syscall.SIGPOLL,
30-
"PROF": syscall.SIGPROF,
31-
"PWR": syscall.SIGPWR,
32-
"QUIT": syscall.SIGQUIT,
33-
"SEGV": syscall.SIGSEGV,
34-
"STKFLT": syscall.SIGSTKFLT,
35-
"STOP": syscall.SIGSTOP,
36-
"SYS": syscall.SIGSYS,
37-
"TERM": syscall.SIGTERM,
38-
"TRAP": syscall.SIGTRAP,
39-
"TSTP": syscall.SIGTSTP,
40-
"TTIN": syscall.SIGTTIN,
41-
"TTOU": syscall.SIGTTOU,
42-
"UNUSED": syscall.SIGUNUSED,
43-
"URG": syscall.SIGURG,
44-
"USR1": syscall.SIGUSR1,
45-
"USR2": syscall.SIGUSR2,
46-
"VTALRM": syscall.SIGVTALRM,
47-
"WINCH": syscall.SIGWINCH,
48-
"XCPU": syscall.SIGXCPU,
49-
"XFSZ": syscall.SIGXFSZ,
17+
"ABRT": unix.SIGABRT,
18+
"ALRM": unix.SIGALRM,
19+
"BUS": unix.SIGBUS,
20+
"CHLD": unix.SIGCHLD,
21+
"CLD": unix.SIGCLD,
22+
"CONT": unix.SIGCONT,
23+
"FPE": unix.SIGFPE,
24+
"HUP": unix.SIGHUP,
25+
"ILL": unix.SIGILL,
26+
"INT": unix.SIGINT,
27+
"IO": unix.SIGIO,
28+
"IOT": unix.SIGIOT,
29+
"KILL": unix.SIGKILL,
30+
"PIPE": unix.SIGPIPE,
31+
"POLL": unix.SIGPOLL,
32+
"PROF": unix.SIGPROF,
33+
"PWR": unix.SIGPWR,
34+
"QUIT": unix.SIGQUIT,
35+
"SEGV": unix.SIGSEGV,
36+
"STKFLT": unix.SIGSTKFLT,
37+
"STOP": unix.SIGSTOP,
38+
"SYS": unix.SIGSYS,
39+
"TERM": unix.SIGTERM,
40+
"TRAP": unix.SIGTRAP,
41+
"TSTP": unix.SIGTSTP,
42+
"TTIN": unix.SIGTTIN,
43+
"TTOU": unix.SIGTTOU,
44+
"UNUSED": unix.SIGUNUSED,
45+
"URG": unix.SIGURG,
46+
"USR1": unix.SIGUSR1,
47+
"USR2": unix.SIGUSR2,
48+
"VTALRM": unix.SIGVTALRM,
49+
"WINCH": unix.SIGWINCH,
50+
"XCPU": unix.SIGXCPU,
51+
"XFSZ": unix.SIGXFSZ,
5052
}
5153

5254
var killCommand = cli.Command{

utils_linux.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99
"os"
1010
"path/filepath"
1111
"strconv"
12-
"syscall"
1312

1413
"github.com/Sirupsen/logrus"
1514
"github.com/coreos/go-systemd/activation"
@@ -20,6 +19,8 @@ import (
2019
"github.com/opencontainers/runc/libcontainer/utils"
2120
"github.com/opencontainers/runtime-spec/specs-go"
2221
"github.com/urfave/cli"
22+
23+
"golang.org/x/sys/unix"
2324
)
2425

2526
var errEmptyID = errors.New("container id cannot be empty")
@@ -316,7 +317,7 @@ func (r *runner) destroy() {
316317
}
317318

318319
func (r *runner) terminate(p *libcontainer.Process) {
319-
_ = p.Signal(syscall.SIGKILL)
320+
_ = p.Signal(unix.SIGKILL)
320321
_, _ = p.Wait()
321322
}
322323

0 commit comments

Comments
 (0)