Malfunctioning End Unit Turn tappable label.

[ghost]

Abstract:

Unstable consequences happen when tapping the End Unit Turn tappable label of the contextual menu spawned from double tapping a unit in game. Sometimes the action takes effect as desired. Sometimes not.

How to reproduce:

• Load any game.

• Tap a unit with available movement points. Tap it again. And again. And again. And again. There are two types of taps: one highlights the unit's avatar inside the hex, the other unhighlights it.

• After an unhighlighting tap, tap it again and hold (it will be a highlighting type of tap). A contextual menu appears. Tap the label End Unit Turn. The unit's orb changed to a moved orb. Tap it again (it will be an unhighlighting type of tap). Tap it again and hold (it will be a highlighting type of tap). A contextual menu appears. Tap the label End Unit Turn. The unit's orb changed either to an unmoved orb, or to a partially moved orb.

• After a highlighting tap, tap it again and hold (it will be an unhighlighting type of tap). A contextual menu appears. Tap the label End Unit Turn. The unit's orb has not changed.

• After a highlighting tap, double tap it again. A contextual menu appears. Tap the label End Unit Turn. The unit's orb changed to a moved orb. Double tap it again. A contextual menu appears. Tap the label End Unit Turn. The unit's orb changed either to an unmoved orb, or to a partially moved orb.

• After an unhighlighting tap, double tap it again. A contextual menu appears. Tap the label End Unit Turn. The unit's orb has not changed.

Information on the wesnoth_ios local clone:

TinyGUI_1.14.4 fff304dde559+dirty

$ git log --pretty=%H | head -1
b68de6a2b384514bcb24d2b2583521f716afd1ca
$ git log --pretty=%B | head -1
Add my own namespace.
$ git status
On branch TinyGUI_1.14.4
Your branch is ahead of 'hrubymar10/TinyGUI_1.14.4' by 1 commit.
  (use "git push" to publish your local commits)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)

	modified:   battleforwesnoth/battleforwesnoth.xcodeproj/project.pbxproj
	modified:   lib/iOS_boost_1_60 (untracked content)

no changes added to commit (use "git add" and/or "git commit -a")
$ pushd lib/iOS_boost_1_60/
$ git status
HEAD detached at 48903ec0
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	libs/boost/ios/libboost.a

nothing added to commit but untracked files present (use "git add" to track)
$ _

Information on the wesnoth local clone:

TinyGUI_1.14.4 68d52b5027ea+dirty

$ git status
On branch TinyGUI_1.14.4
Your branch is up-to-date with 'hrubymar10/TinyGUI_1.14.4'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   src/game_config.cpp

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	projectfiles/wesnoth_ios/

no changes added to commit (use "git add" and/or "git commit -a")
$ git diff
diff --git a/src/game_config.cpp b/src/game_config.cpp
index 9058b794cc..4f8a592fb8 100644
--- a/src/game_config.cpp
+++ b/src/game_config.cpp
@@ -24,7 +24,7 @@
 #include "wesconfig.h"
 #include "serialization/string_utils.hpp"
 #ifdef LOAD_REVISION
-#include "revision.h"
+//#include "revision.h"
 #endif
 
 static lg::log_domain log_engine("engine");
@@ -50,6 +50,8 @@ const version_info test_version("test");
 #define VERSION WESNOTH_XSTR(RC_VERSION_MAJOR) "." WESNOTH_XSTR(RC_VERSION_MINOR) "." WESNOTH_XSTR(RC_VERSION_REVISION)
 const std::string revision = std::string(VERSION);// + " (" + VCS_SHORT_HASH ")";
 #elif defined(__IPHONEOS__) && DEBUG
+#define VCS_FULL_HASH "00000000"
+#define VCS_WC_MODIFIED true
     const std::string revision = std::string(VERSION) + " (" + std::string(VCS_FULL_HASH).substr(0,7) + (VCS_WC_MODIFIED ? "-Modified" : "-Clean") + ")";
 #elif defined(REVISION)
 const std::string revision = VERSION " (" REVISION ")";
$ _

Supervisor version:

10.3.3 (14G60).

Device model:

iPad (4th gen.) MD523TY/A.