From 8a5d50dbf16057794e389e68dede323dd49d9606 Mon Sep 17 00:00:00 2001
From: Filip Leitner <leitnerfilip@gmail.com>
Date: Mon, 12 Feb 2024 11:41:53 +0100
Subject: [PATCH] fix(styler): Symbolizer defaults

Add default parameter values for more predictable UX
---
 .../components/styler/rule/rule.component.ts  | 42 +++++++++++++++----
 .../fill-symbolizer.component.ts              | 20 ++++++++-
 2 files changed, 54 insertions(+), 8 deletions(-)

diff --git a/projects/hslayers/components/styler/rule/rule.component.ts b/projects/hslayers/components/styler/rule/rule.component.ts
index 5b96fe9dff..ede657423c 100644
--- a/projects/hslayers/components/styler/rule/rule.component.ts
+++ b/projects/hslayers/components/styler/rule/rule.component.ts
@@ -22,21 +22,49 @@ export class HsRuleComponent extends HsStylerPartBaseComponent {
     super();
   }
   async addSymbolizer(kind: SymbolizerKind): Promise<void> {
-    const symbolizer = {kind, color: '#000'};
+    const symbolizer = {kind, color: '#000000'};
     if (kind === Kinds.text) {
-      Object.assign(symbolizer, {size: 12, offset: [0, 0]});
+      Object.assign(symbolizer, {
+        size: 12,
+        offset: [0, 0],
+        font: ['Arial'],
+        fontStyle: 'normal',
+        fontWeight: 'normal',
+        rotation: 0,
+      });
     }
     if (kind === Kinds.fill) {
-      Object.assign(symbolizer, {outlineColor: '#000'});
+      Object.assign(symbolizer, {
+        outlineColor: '#ffffff',
+        opacity: 1,
+        outlineOpacity: 0.5,
+        outlineWidth: 2,
+      });
     }
     if (kind == Kinds.icon) {
-      Object.assign(symbolizer, {offset: [0.5, 0.5]});
+      Object.assign(symbolizer, {
+        offset: [0.5, 0.5],
+        opacity: 1,
+        size: 20,
+        image: 'assets/img/icons/information78.svg',
+      });
     }
     if (kind == Kinds.mark) {
-      Object.assign(symbolizer, {wellKnownName: 'circle'});
+      Object.assign(symbolizer, {
+        wellKnownName: 'circle',
+        radius: 7,
+        fillOpacity: 1,
+        strokeColor: '#ffffff',
+        strokeOpacity: 0.25,
+        strokeWidth: 2,
+      });
     }
-    if (kind == Kinds.icon) {
-      Object.assign(symbolizer, {image: 'assets/img/icons/information78.svg'});
+    if (kind == Kinds.line) {
+      Object.assign(symbolizer, {
+        width: 2,
+        join: 'round',
+        cap: 'round',
+      });
     }
     this.rule.symbolizers.push(symbolizer);
     this.menuRef.close();
diff --git a/projects/hslayers/components/styler/symbolizers/fill-symbolizer/fill-symbolizer.component.ts b/projects/hslayers/components/styler/symbolizers/fill-symbolizer/fill-symbolizer.component.ts
index 937e5197fa..67430db513 100644
--- a/projects/hslayers/components/styler/symbolizers/fill-symbolizer/fill-symbolizer.component.ts
+++ b/projects/hslayers/components/styler/symbolizers/fill-symbolizer/fill-symbolizer.component.ts
@@ -22,7 +22,25 @@ export class HsFillSymbolizerComponent extends HsStylerPartBaseComponent {
   kinds = Kinds;
 
   addSymbolizer(attribute: string, kind: SymbolizerKind): void {
-    this.symbolizer[attribute] = {kind};
+    const symbolizer = {kind, color: '#000000', opacity: 1};
+    if (kind == Kinds.icon) {
+      Object.assign(symbolizer, {
+        offset: [0.5, 0.5],
+        size: 20,
+        image: 'assets/img/icons/information78.svg',
+      });
+    }
+    if (kind == Kinds.mark) {
+      Object.assign(symbolizer, {
+        wellKnownName: 'circle',
+        radius: 7,
+        fillOpacity: 1,
+        strokeColor: '#ffffff',
+        strokeOpacity: 0.25,
+        strokeWidth: 2,
+      });
+    }
+    this.symbolizer[attribute] = symbolizer;
     this.menuRef.close();
     this.emitChange();
   }