fix(sd3): fix deletion of text_encoders etc (#8951)

townwish4git · sayakpaul · yiyixuxu · web-flow · commit d25eb5d38583 · 2024-08-18T15:37:40.000-10:00
Co-authored-by: Sayak Paul &lt;spsayakpaul@gmail.com&gt;
Co-authored-by: YiYi Xu &lt;yixu310@gmail.com&gt;
diff --git a/examples/dreambooth/train_dreambooth_lora_sd3.py b/examples/dreambooth/train_dreambooth_lora_sd3.py
@@ -1454,7 +1454,7 @@ def compute_text_embeddings(prompt, text_encoders, tokenizers):
             )
 
     # Clear the memory here
-    if not args.train_text_encoder and train_dataset.custom_instance_prompts:
+    if not args.train_text_encoder and not train_dataset.custom_instance_prompts:
         del tokenizers, text_encoders
         # Explicitly delete the objects as well, otherwise only the lists are deleted and the original references remain, preventing garbage collection
         del text_encoder_one, text_encoder_two, text_encoder_three

Original file line number	Diff line number	Diff line change
`@@ -1454,7 +1454,7 @@ def compute_text_embeddings(prompt, text_encoders, tokenizers):`
`1454`	`1454`	`)`
`1455`	`1455`
`1456`	`1456`	`# Clear the memory here`
`1457`		`- if not args.train_text_encoder and train_dataset.custom_instance_prompts:`
	`1457`	`+ if not args.train_text_encoder and not train_dataset.custom_instance_prompts:`
`1458`	`1458`	`del tokenizers, text_encoders`
`1459`	`1459`	`# Explicitly delete the objects as well, otherwise only the lists are deleted and the original references remain, preventing garbage collection`
`1460`	`1460`	`del text_encoder_one, text_encoder_two, text_encoder_three`