From e085e344cb59073241b6d011c2f094d1ba907b5d Mon Sep 17 00:00:00 2001
From: dominikn <dominik.nwk@gmail.com>
Date: Fri, 24 May 2024 15:22:01 +0200
Subject: [PATCH] fix PathJoinSubstitution

---
 rosbot_utils/rosbot_utils/flash_firmware.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/rosbot_utils/rosbot_utils/flash_firmware.py b/rosbot_utils/rosbot_utils/flash_firmware.py
index 682e7592..9d92840f 100755
--- a/rosbot_utils/rosbot_utils/flash_firmware.py
+++ b/rosbot_utils/rosbot_utils/flash_firmware.py
@@ -22,7 +22,10 @@
 import sys
 
 import requests
-from launch_ros.substitutions import FindPackageShare
+from launch.substitutions import (
+    PathJoinSubstitution,
+)
+from launch_ros.substitutions import FindPackageShare 
 
 # Global variable to hold the subprocess reference
 subproc = None
@@ -53,7 +56,8 @@ def find_firmware_file():
     package_install_directory = FindPackageShare("rosbot_utils")
 
     # Construct the path to the firmware directory
-    firmware_dir = os.path.join(package_install_directory, "firmware")
+    # firmware_dir = os.path.join(package_install_directory, "firmware")
+    firmware_dir = PathJoinSubstitution([package_install_directory, "firmware"])
     firmware_files = glob.glob(os.path.join(firmware_dir, f"firmware-{firmware_version}.bin"))
 
     if not firmware_files: