Skip to content

Commit 75d8a88

Browse files
committed
fix: user agent macbook 추가가
1 parent 8f27219 commit 75d8a88

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/utils/shootingManager.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,7 @@ export default class ShootingManager {
6464
// HJ TODO: cleanup이 맞을까?
6565
this.setUpCanvas(canvasEl);
6666
this.setUpVideo(
67-
uaParserManager.getOsName() === "iOS"
68-
? recordVideoMovSrc
69-
: recordVideoWebmSrc
67+
uaParserManager.isApple() ? recordVideoMovSrc : recordVideoWebmSrc
7068
);
7169
// this.setUpAudio(audioSrc);
7270
this.m_videoName = name;
@@ -173,8 +171,7 @@ export default class ShootingManager {
173171

174172
// the user interaction should be need to use audio context
175173
private setUpRecorder(onEnd: (blob: Blob) => void) {
176-
const mimeType =
177-
uaParserManager.getOsName() === "iOS" ? "video/mp4" : "video/webm";
174+
const mimeType = uaParserManager.isApple() ? "video/mp4" : "video/webm";
178175

179176
console.debug(CONSOLE_PREFIX, `mimeType : ${mimeType}`);
180177

src/utils/uaParserManager.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,20 @@ class UaParserManager {
116116
return this.m_device;
117117
}
118118

119+
public isApple() {
120+
const osName = this.getOsName();
121+
122+
return (["Mac OS", "iOS"] as const).some(os => os === osName)
123+
}
124+
119125
public getOsName() {
120126
return this.getOs().name as OsType;
121127
}
122128

123129
private getOs() {
124130
if (!this.m_os) {
125131
this.m_os = this.m_parser.getOS();
132+
console.debug(CONSOLE_PREFIX, "getOs", this.m_os);
126133
}
127134

128135
return this.m_os;

0 commit comments

Comments
 (0)