Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

Refactor with proper object inheritance #2

Open
ethanlindley opened this issue Feb 3, 2018 · 2 comments
Open

Refactor with proper object inheritance #2

ethanlindley opened this issue Feb 3, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@ethanlindley
Copy link

You've a good idea and most of the code is pretty decent, but it's not good practice to instantiate variables and methods using the static modifier. I'd recommend learning how Java's inheritance works, and then refactoring the repository as needed. I can link some of Java's documentation regarding how to do so if you're interested.

@hyperdefined
Copy link
Owner

The code is probably really terrible. I just wanted to make a program that will work.

I can't really figure out when I should use the static modifier. Feel free to link some important info.

@hyperdefined hyperdefined added the enhancement New feature or request label Feb 3, 2018
@ethanlindley
Copy link
Author

I tried refactoring the code a bit, but it ended up with me rewriting a few modules. Take a look here and here for information regarding object inheritance in Java. Let me know if you have any more questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants