You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current comment for hyper_buf_copy in the header says:
/* Create a new `hyper_buf *` by copying the provided bytes. This makes an owned copy of the bytes, so the `buf` argument can be freed or changed afterwards.*/
I think it would be helpful to users to mention that this can return NULL in cases of out of memory. Because it can return that then, can't it?
The text was updated successfully, but these errors were encountered:
Yes, you're right! This would be a simple doc change. And in fact the code is already prepared to return NULL on panic. However, it seems there's no progress on the issue to allow setting OOM to panic instead of abort (I recorded my check-in in #2396).
The current comment for
hyper_buf_copy
in the header says:I think it would be helpful to users to mention that this can return NULL in cases of out of memory. Because it can return that then, can't it?
The text was updated successfully, but these errors were encountered: