Merge pull request #1420 from hyperledger/enhance-ecrecover-feature

Implement ecrecover precompile

Author: seanyoung

acm/account.go

@@ -18,7 +18,7 @@ import (
 
 var GlobalPermissionsAddress = crypto.Address(binary.Zero160)
 
-func NewAccount(pubKey crypto.PublicKey) *Account {
+func NewAccount(pubKey *crypto.PublicKey) *Account {
 	return &Account{
 		Address:   pubKey.GetAddress(),
 		PublicKey: pubKey,

acm/acm.pb.go

@@ -137,7 +137,6 @@ func NativeToWei(n uint64) *big.Int {
 	return new(big.Int).Mul(x, eth)
 }
 
-func WeiToNative(n []byte) *big.Int {
-	x := new(big.Int).SetBytes(n)
+func WeiToNative(x *big.Int) *big.Int {
 	return new(big.Int).Div(x, eth)
 }

acm/balance/balance.go

@@ -24,6 +24,6 @@ func TestSort(t *testing.T) {
 func TestEtherConversion(t *testing.T) {
 	wei := NativeToWei(1)
 	assert.Equal(t, wei.String(), "1000000000000000000", "must equal one ether")
-	native := WeiToNative(wei.Bytes())
+	native := WeiToNative(wei)
 	assert.Equal(t, native.Uint64(), uint64(1))
 }

acm/balance/balance_test.go

@@ -24,8 +24,8 @@ func (pa *PrivateAccount) GetAddress() crypto.Address {
 	return pa.concretePrivateAccount.Address
 }
 
-func (pa *PrivateAccount) GetPublicKey() crypto.PublicKey {
-	return pa.concretePrivateAccount.PublicKey
+func (pa *PrivateAccount) GetPublicKey() *crypto.PublicKey {
+	return &pa.concretePrivateAccount.PublicKey
 }
 
 func (pa *PrivateAccount) Sign(msg []byte) (*crypto.Signature, error) {
@@ -78,7 +78,7 @@ func PrivateAccountFromPrivateKey(privateKey crypto.PrivateKey) *PrivateAccount
 	return &PrivateAccount{
 		concretePrivateAccount: &ConcretePrivateAccount{
 			PrivateKey: privateKey,
-			PublicKey:  publicKey,
+			PublicKey:  *publicKey,
 			Address:    publicKey.GetAddress(),
 		},
 	}
@@ -102,7 +102,7 @@ func GeneratePrivateAccount(ct crypto.CurveType) (*PrivateAccount, error) {
 	publicKey := privateKey.GetPublicKey()
 	return ConcretePrivateAccount{
 		Address:    publicKey.GetAddress(),
-		PublicKey:  publicKey,
+		PublicKey:  *publicKey,
 		PrivateKey: privateKey,
 	}.PrivateAccount(), nil
 }
@@ -111,7 +111,7 @@ func privateAccount(privateKey crypto.PrivateKey) *PrivateAccount {
 	publicKey := privateKey.GetPublicKey()
 	return ConcretePrivateAccount{
 		Address:    publicKey.GetAddress(),
-		PublicKey:  publicKey,
+		PublicKey:  *publicKey,
 		PrivateKey: privateKey,
 	}.PrivateAccount()
 }

acm/private_account.go

@@ -47,7 +47,7 @@ func (vc *Bucket) Power(id crypto.Address) (*big.Int, error) {
 }
 
 // SetPower ensures that validator power would not change too quickly in a single block
-func (vc *Bucket) SetPower(id crypto.PublicKey, power *big.Int) (*big.Int, error) {
+func (vc *Bucket) SetPower(id *crypto.PublicKey, power *big.Int) (*big.Int, error) {
 	const errHeader = "Bucket.SetPower():"
 	err := checkPower(power)
 	if err != nil {

acm/validator/bucket.go

@@ -63,7 +63,7 @@ func (vc *Ring) GetPower(id crypto.Address) *big.Int {
 	return vc.Head().Previous.GetPower(id)
 }
 
-func (vc *Ring) SetPower(id crypto.PublicKey, power *big.Int) (*big.Int, error) {
+func (vc *Ring) SetPower(id *crypto.PublicKey, power *big.Int) (*big.Int, error) {
 	return vc.Head().SetPower(id, power)
 }
 

acm/validator/ring.go

@@ -44,12 +44,12 @@ func NewTrimSet() *Set {
 }
 
 // Implements Writer, but will never error
-func (vs *Set) SetPower(id crypto.PublicKey, power *big.Int) (*big.Int, error) {
+func (vs *Set) SetPower(id *crypto.PublicKey, power *big.Int) (*big.Int, error) {
 	return vs.ChangePower(id, power), nil
 }
 
 // Add the power of a validator and returns the flow into that validator
-func (vs *Set) ChangePower(id crypto.PublicKey, power *big.Int) *big.Int {
+func (vs *Set) ChangePower(id *crypto.PublicKey, power *big.Int) *big.Int {
 	address := id.GetAddress()
 	// Calculate flow into this validator (positive means in, negative means out)
 	flow := vs.Flow(id, power)
@@ -78,7 +78,7 @@ func (vs *Set) MaxFlow() *big.Int {
 }
 
 // Returns the flow that would be induced by a validator power change
-func (vs *Set) Flow(id crypto.PublicKey, power *big.Int) *big.Int {
+func (vs *Set) Flow(id *crypto.PublicKey, power *big.Int) *big.Int {
 	return new(big.Int).Sub(power, vs.GetPower(id.GetAddress()))
 }
 

acm/validator/set.go

@@ -20,6 +20,6 @@ func TestValidators_AlterPower(t *testing.T) {
 	assertZero(t, vs.TotalPower())
 }
 
-func pubKey(secret interface{}) crypto.PublicKey {
+func pubKey(secret interface{}) *crypto.PublicKey {
 	return acm.NewAccountFromSecret(fmt.Sprintf("%v", secret)).PublicKey
 }

acm/validator/set_test.go

@@ -9,7 +9,7 @@ import (
 	"github.com/hyperledger/burrow/acm"
 )
 
-func New(publicKey crypto.PublicKey, power *big.Int) *Validator {
+func New(publicKey *crypto.PublicKey, power *big.Int) *Validator {
 	v := &Validator{
 		PublicKey: publicKey,
 		Power:     power.Uint64(),