refactor: replace sort.Slice with slices.Sort for natural ordering (#635)

Signed-off-by: yingshanghuangqiao <[email protected]>

Author: yingshanghuangqiao

pkg/consensus/consensus.go

@@ -8,7 +8,7 @@ package consensus
 import (
 	"errors"
 	"fmt"
-	"sort"
+	"slices"
 	"strings"
 	"sync"
 	"sync/atomic"
@@ -378,9 +378,7 @@ func (c *Consensus) setNodes(nodes []uint64) {
 func sortNodes(nodes []uint64) []uint64 {
 	sorted := make([]uint64, len(nodes))
 	copy(sorted, nodes)
-	sort.Slice(sorted, func(i, j int) bool {
-		return sorted[i] < sorted[j]
-	})
+	slices.Sort(sorted)
 	return sorted
 }
 

pkg/wal/util.go

@@ -11,6 +11,7 @@ import (
 	"io"
 	"os"
 	"path/filepath"
+	"slices"
 	"sort"
 	"strings"
 
@@ -132,11 +133,7 @@ func checkWalFiles(logger api.Logger, dirName string, walNames []string) ([]uint
 		}
 	}
 
-	sort.Slice(indexes,
-		func(i, j int) bool {
-			return indexes[i] < indexes[j]
-		},
-	)
+	slices.Sort(indexes)
 
 	return indexes, nil
 }

test/network.go

@@ -8,7 +8,7 @@ package test
 import (
 	"fmt"
 	"math/rand"
-	"sort"
+	"slices"
 	"sync"
 
 	"github.com/hyperledger-labs/SmartBFT/smartbftprotos"
@@ -213,7 +213,7 @@ func (node *Node) SendTransaction(targetID uint64, request []byte) {
 // Nodes returns the ids of all nodes in the network
 func (node *Node) Nodes() []uint64 {
 	res := node.n.getAll()
-	sort.Slice(res, func(i, j int) bool { return res[i] < res[j] })
+	slices.Sort(res)
 	return res
 }