Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

Commit a01bd58

Browse files
Merge branch 'master' into fix-dash-sizing
2 parents e4ede85 + aee4798 commit a01bd58

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

projects/components/src/combo-box/combo-box-api.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
export interface ComboBoxOption<TValue = string> {
22
text: string;
33
value: TValue;
4+
tooltip?: string;
45
}
56

67
export interface ComboBoxResult<TValue = string> {

projects/components/src/combo-box/combo-box.component.ts

+1
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ import { ComboBoxMode, ComboBoxOption, ComboBoxResult } from './combo-box-api';
8585
*ngFor="let option of this.filteredOptions; index as i"
8686
[class.selected]="this.highlightedOptionIndex === i"
8787
(click)="this.onOptionClick(option)"
88+
[htcTooltip]="option.tooltip ? option.tooltip : ''"
8889
class="popover-item"
8990
>
9091
<div [innerHtml]="option.text | htcHighlight: this.text"></div>

projects/components/src/combo-box/combo-box.module.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ import { FormattingModule } from '@hypertrace/common';
55
import { ButtonModule } from '../button/button.module';
66
import { IconModule } from '../icon/icon.module';
77
import { PopoverModule } from '../popover/popover.module';
8+
import { TooltipModule } from '../tooltip/tooltip.module';
89
import { ComboBoxComponent } from './combo-box.component';
910

1011
@NgModule({
11-
imports: [CommonModule, PopoverModule, IconModule, FormsModule, FormattingModule, ButtonModule],
12+
imports: [CommonModule, PopoverModule, IconModule, FormsModule, FormattingModule, ButtonModule, TooltipModule],
1213
declarations: [ComboBoxComponent],
1314
exports: [ComboBoxComponent]
1415
})

projects/distributed-tracing/src/shared/components/filter-bar/filter/filter.component.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ export class FilterComponent implements OnInit, OnChanges {
106106
private mapToComboBoxOption(filter: IncompleteFilter): ComboBoxOption<IncompleteFilter> {
107107
return {
108108
text: filter.userString,
109-
value: filter
109+
value: filter,
110+
tooltip: `${filter.userString} (${filter.field})`
110111
};
111112
}
112113
}

0 commit comments

Comments
 (0)