Skip to content

Commit 56d5f1f

Browse files
authored
Align packages names and shading with OTEL (#183)
* Use javaagent packate to align with OTEL Signed-off-by: Pavol Loffay <[email protected]> * Fix missing Signed-off-by: Pavol Loffay <[email protected]> * Align shading Signed-off-by: Pavol Loffay <[email protected]> * Use extends class Signed-off-by: Pavol Loffay <[email protected]> * Fix format Signed-off-by: Pavol Loffay <[email protected]> * Use named Signed-off-by: Pavol Loffay <[email protected]>
1 parent 592d5bb commit 56d5f1f

File tree

66 files changed

+121
-117
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+121
-117
lines changed
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.apachehttpclient.v4_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0;
1818

1919
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.implementsInterface;
2020
import static net.bytebuddy.matcher.ElementMatchers.hasSuperType;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.apachehttpclient.v4_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0;
1818

1919
public class ApacheHttpClientInstrumentationName {
2020
public static final String PRIMARY = "httpclient";
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.apachehttpclient.v4_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0;
1818

1919
import com.blogspot.mydailyjava.weaklockfree.WeakConcurrentMap;
2020
import io.opentelemetry.api.trace.Span;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.apachehttpclient.v4_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0;
1818

1919
import io.opentelemetry.api.common.AttributeKey;
2020
import io.opentelemetry.api.trace.Span;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.apachehttpclient.v4_0.readall;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0.readall;
1818

1919
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.implementsInterface;
2020
import static net.bytebuddy.matcher.ElementMatchers.isAbstract;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.apachehttpclient.v4_0.readall;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0.readall;
1818

1919
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.safeHasSuperType;
2020
import static io.opentelemetry.javaagent.tooling.matcher.NameMatchers.namedOneOf;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.apachehttpclient.v4_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.apachehttpclient.v4_0;
1818

1919
import io.opentelemetry.api.trace.Span;
2020
import io.opentelemetry.sdk.trace.data.SpanData;

instrumentation/build.gradle.kts

+7-9
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,19 @@ tasks {
6262

6363
exclude("**/module-info.class")
6464

65-
// rewrite dependencies calling Logger.getLogger
65+
relocate("org.slf4j", "io.opentelemetry.javaagent.slf4j")
6666
relocate("java.util.logging.Logger", "io.opentelemetry.javaagent.bootstrap.PatchLogger")
6767

68-
// prevents conflict with library instrumentation
68+
// // prevents conflict with library instrumentation
6969
relocate("io.opentelemetry.instrumentation.api", "io.opentelemetry.javaagent.shaded.instrumentation.api")
70-
relocate("org.slf4j", "io.opentelemetry.javaagent.slf4j")
71-
72-
// relocate OpenTelemetry API
73-
relocate("io.opentelemetry.api", "io.opentelemetry.javaagent.shaded.io.opentelemetry.api")
74-
relocate("io.opentelemetry.context", "io.opentelemetry.javaagent.shaded.io.opentelemetry.context")
75-
7670
//opentelemetry rewrite library instrumentation dependencies
7771
relocate("io.opentelemetry.instrumentation", "io.opentelemetry.javaagent.shaded.instrumentation") {
7872
exclude("io.opentelemetry.javaagent.instrumentation.**")
79-
exclude("io.opentelemetry.instrumentation.hypertrace.**")
8073
}
74+
75+
// relocate OpenTelemetry API
76+
relocate("io.opentelemetry.api", "io.opentelemetry.javaagent.shaded.io.opentelemetry.api")
77+
relocate("io.opentelemetry.spi", "io.opentelemetry.javaagent.shaded.io.opentelemetry.spi")
78+
relocate("io.opentelemetry.context", "io.opentelemetry.javaagent.shaded.io.opentelemetry.context")
8179
}
8280
}
+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5;
1818

1919
public class GrpcInstrumentationName {
2020
public static final String PRIMARY = "grpc";
+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5;
1818

1919
import io.grpc.Metadata;
2020

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5;
1818

1919
import com.google.protobuf.InvalidProtocolBufferException;
2020
import com.google.protobuf.Message;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5;
1818

1919
import static net.bytebuddy.matcher.ElementMatchers.failSafe;
2020
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.client;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.client;
1818

1919
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass;
2020
import static java.util.Collections.singletonMap;
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.client;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.client;
1818

1919
import com.google.auto.service.AutoService;
20-
import io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
20+
import io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
2121
import io.opentelemetry.javaagent.tooling.InstrumentationModule;
2222
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
2323
import java.util.Collections;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.client;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.client;
1818

1919
import io.grpc.CallOptions;
2020
import io.grpc.Channel;
@@ -26,8 +26,8 @@
2626
import io.grpc.Metadata;
2727
import io.grpc.MethodDescriptor;
2828
import io.opentelemetry.api.trace.Span;
29-
import io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
30-
import io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.GrpcSpanDecorator;
29+
import io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
30+
import io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.GrpcSpanDecorator;
3131
import org.hypertrace.agent.core.HypertraceConfig;
3232
import org.hypertrace.agent.core.HypertraceSemanticAttributes;
3333

Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.server;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.server;
1818

1919
import static io.opentelemetry.javaagent.tooling.ClassLoaderMatcher.hasClassesNamed;
2020
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.safeHasSuperType;
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.server;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.server;
1818

1919
import com.google.auto.service.AutoService;
20-
import io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
20+
import io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
2121
import io.opentelemetry.javaagent.tooling.InstrumentationModule;
2222
import io.opentelemetry.javaagent.tooling.TypeInstrumentation;
2323
import java.util.Collections;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.server;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.server;
1818

1919
import io.grpc.ForwardingServerCall;
2020
import io.grpc.ForwardingServerCallListener;
@@ -25,8 +25,8 @@
2525
import io.grpc.ServerInterceptor;
2626
import io.grpc.Status;
2727
import io.opentelemetry.api.trace.Span;
28-
import io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
29-
import io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.GrpcSpanDecorator;
28+
import io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.GrpcInstrumentationName;
29+
import io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.GrpcSpanDecorator;
3030
import java.util.Map;
3131
import org.hypertrace.agent.core.HypertraceConfig;
3232
import org.hypertrace.agent.core.HypertraceSemanticAttributes;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5.server;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5.server;
1818

1919
import io.grpc.ServerCall;
2020

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5;
1818

1919
import com.google.protobuf.util.JsonFormat;
2020
import io.grpc.ForwardingServerCall;
+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.grpc.v1_5;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.grpc.v1_5;
1818

1919
import io.grpc.stub.StreamObserver;
2020
import org.hypertrace.example.GreeterGrpc;
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.java.inputstream;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.java.inputstream;
1818

19-
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.safeHasSuperType;
20-
import static io.opentelemetry.javaagent.tooling.matcher.NameMatchers.namedOneOf;
19+
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass;
2120
import static net.bytebuddy.matcher.ElementMatchers.is;
2221
import static net.bytebuddy.matcher.ElementMatchers.isPublic;
22+
import static net.bytebuddy.matcher.ElementMatchers.named;
2323
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
2424
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
2525

@@ -67,23 +67,23 @@ static class InputStreamInstrumentation implements TypeInstrumentation {
6767

6868
@Override
6969
public ElementMatcher<? super TypeDescription> typeMatcher() {
70-
return safeHasSuperType(namedOneOf("java.io.InputStream"));
70+
return extendsClass(named("java.io.InputStream"));
7171
}
7272

7373
@Override
7474
public Map<? extends ElementMatcher<? super MethodDescription>, String> transformers() {
7575
Map<ElementMatcher<? super MethodDescription>, String> transformers = new HashMap<>();
7676
transformers.put(
77-
namedOneOf("read").and(takesArguments(0)).and(isPublic()),
77+
named("read").and(takesArguments(0)).and(isPublic()),
7878
InputStreamInstrumentationModule.class.getName() + "$InputStream_ReadNoArgsAdvice");
7979
transformers.put(
80-
namedOneOf("read")
80+
named("read")
8181
.and(takesArguments(1))
8282
.and(takesArgument(0, is(byte[].class)))
8383
.and(isPublic()),
8484
InputStreamInstrumentationModule.class.getName() + "$InputStream_ReadByteArrayAdvice");
8585
transformers.put(
86-
namedOneOf("read")
86+
named("read")
8787
.and(takesArguments(3))
8888
.and(takesArgument(0, is(byte[].class)))
8989
.and(takesArgument(1, is(int.class)))
@@ -92,10 +92,10 @@ public Map<? extends ElementMatcher<? super MethodDescription>, String> transfor
9292
InputStreamInstrumentationModule.class.getName()
9393
+ "$InputStream_ReadByteArrayOffsetAdvice");
9494
transformers.put(
95-
namedOneOf("readAllBytes").and(takesArguments(0)).and(isPublic()),
95+
named("readAllBytes").and(takesArguments(0)).and(isPublic()),
9696
InputStream_ReadAllBytes.class.getName());
9797
transformers.put(
98-
namedOneOf("readNBytes")
98+
named("readNBytes")
9999
.and(takesArguments(0))
100100
.and(takesArgument(0, is(byte[].class)))
101101
.and(takesArgument(1, is(int.class)))
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.java.inputstream;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.java.inputstream;
1818

1919
import io.opentelemetry.api.OpenTelemetry;
2020
import io.opentelemetry.api.common.AttributeKey;
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.java.outputstream;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.java.outputstream;
1818

1919
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass;
20-
import static io.opentelemetry.javaagent.tooling.matcher.NameMatchers.namedOneOf;
2120
import static net.bytebuddy.matcher.ElementMatchers.is;
2221
import static net.bytebuddy.matcher.ElementMatchers.isPublic;
2322
import static net.bytebuddy.matcher.ElementMatchers.named;
@@ -71,19 +70,19 @@ public ElementMatcher<? super TypeDescription> typeMatcher() {
7170
public Map<? extends ElementMatcher<? super MethodDescription>, String> transformers() {
7271
Map<ElementMatcher<? super MethodDescription>, String> transformers = new HashMap<>();
7372
transformers.put(
74-
namedOneOf("write")
73+
named("write")
7574
.and(takesArguments(1))
7675
.and(takesArgument(0, is(int.class)))
7776
.and(isPublic()),
7877
OutputStreamInstrumentationModule.class.getName() + "$OutputStream_WriteIntAdvice");
7978
transformers.put(
80-
namedOneOf("write")
79+
named("write")
8180
.and(takesArguments(1))
8281
.and(takesArgument(0, is(byte[].class)))
8382
.and(isPublic()),
8483
OutputStreamInstrumentationModule.class.getName() + "$OutputStream_WriteByteArrAdvice");
8584
transformers.put(
86-
namedOneOf("write")
85+
named("write")
8786
.and(takesArguments(3))
8887
.and(takesArgument(0, is(byte[].class)))
8988
.and(takesArgument(1, is(int.class)))
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.java.outputstream;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.java.outputstream;
1818

1919
import io.opentelemetry.javaagent.instrumentation.api.CallDepthThreadLocalMap;
2020
import java.io.IOException;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.jaxrs.v2_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.jaxrs.v2_0;
1818

1919
import io.opentelemetry.api.common.AttributeKey;
2020
import io.opentelemetry.api.trace.Span;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.jaxrs.v2_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.jaxrs.v2_0;
1818

1919
import static io.opentelemetry.javaagent.tooling.ClassLoaderMatcher.hasClassesNamed;
2020
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.jaxrs.v2_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.jaxrs.v2_0;
1818

1919
public class JaxrsClientBodyInstrumentationName {
2020
public static final String PRIMARY = "jaxrs-client";
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.jaxrs.v2_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.jaxrs.v2_0;
1818

1919
import io.opentelemetry.api.trace.Span;
2020
import io.opentelemetry.context.Context;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package io.opentelemetry.instrumentation.hypertrace.jaxrs.v2_0;
17+
package io.opentelemetry.javaagent.instrumentation.hypertrace.jaxrs.v2_0;
1818

1919
import io.opentelemetry.api.trace.Span;
2020
import io.opentelemetry.sdk.trace.data.SpanData;

0 commit comments

Comments
 (0)