Skip to content

feature: move starship/tests to tests and make tests a JS package #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anmol1696 opened this issue May 6, 2025 · 0 comments · May be fixed by #681
Open

feature: move starship/tests to tests and make tests a JS package #679

Anmol1696 opened this issue May 6, 2025 · 0 comments · May be fixed by #681

Comments

@Anmol1696
Copy link
Collaborator

Overview

Converting the tests to JS will test out the starship-cli the best, since will use it to setup and run and then destroy the tests.

Inherintly there is nothing in the tests that need to be Go specific, additionally then we can also get rid of the clients/go since it is mostly used by the tests only.

Currently test setup is also done by the Makefile in tests using older versions of setup of Starship, although we should have it still just in case, but we can rid of the go part for the tests.

@Anmol1696 Anmol1696 linked a pull request May 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant