Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight @mention when rendering an annotation in the client #6803

Closed
acelaya opened this issue Feb 7, 2025 · 0 comments · Fixed by #6818
Closed

Highlight @mention when rendering an annotation in the client #6803

acelaya opened this issue Feb 7, 2025 · 0 comments · Fixed by #6818
Assignees

Comments

@acelaya
Copy link
Contributor

acelaya commented Feb 7, 2025

Annotations that contain mentions will include the user key prefixed with the @ character.

They should also have a mentions array with the user information. Before rendering the annotation text, we should replace the key-mention with the corresponding username-mention` or display-name-mention.

@mentions should also be links, highlighted in a different color, that take you to the user profile.

Image

Proper accessibility should also be taken into consideration, like making sure the link is underline to not trust just in color contrast.

@acelaya acelaya self-assigned this Feb 7, 2025
@acelaya acelaya changed the title FE - Highlight @mention when rendering an annotation in the client Highlight @mention when rendering an annotation in the client Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant