Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake, Meson: add option controlling building hyprpm #9106

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Conversation

fufexan
Copy link
Member

@fufexan fufexan commented Jan 18, 2025

Describe your PR, what does it fix/add?

Adds an option to control whether hyprpm will be built or not.
Ref: #9067
Wiki ref: hyprwm/hyprland-wiki#949

Usage:
-DNO_HYPRPM:BOOL=TRUE for CMake
-Dhyprpm=disabled for Meson

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Seems to work for both CMake and Meson.

Is it ready for merging, or does it need work?

Ready.

@github-actions github-actions bot added the Nix NixOS issue label Jan 18, 2025
It does not work properly on Nix anyway. If you were using hyprpm in
some way before, please switch to using the `plugins` option in the
HM module (and the upcoming option in the NixOS module, soon™).
@fufexan fufexan merged commit a36fa5c into main Jan 18, 2025
19 checks passed
@fufexan fufexan deleted the hyprpm_option branch January 18, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nix NixOS issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant