Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose bo buffer mapping #12

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Expose bo buffer mapping #12

merged 3 commits into from
Jul 12, 2024

Conversation

UjinT34
Copy link
Contributor

@UjinT34 UjinT34 commented Jul 11, 2024

Expose gbm buffer mapping through beginDataPtr. The mapping is created only once so only flags passed for the first time are used. Can be used to copy data to the gbm buffer if rendering fails (flags = GBM_BO_TRANSFER_WRITE). Assumes 4 bytes per pixel as the most common case for cursor buffers.

@vaxerski
Copy link
Member

Why? It's really slow. I'd rather provide an API to submit CPU buffers for cursors.

@UjinT34
Copy link
Contributor Author

UjinT34 commented Jul 11, 2024

A temporary solution. Not for the hw cursors themselves but for features that require them.
beginDataPtr api already exists. Is there any better way of returning something useful from this function?

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@vaxerski vaxerski merged commit 815df06 into hyprwm:main Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants