Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default trivial dtors #139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/aquamarine/allocator/DRMDumb.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace Aquamarine {

class CDRMDumbAllocator : public IAllocator {
public:
~CDRMDumbAllocator();
~CDRMDumbAllocator() = default;
static Hyprutils::Memory::CSharedPointer<CDRMDumbAllocator> create(int drmfd_, Hyprutils::Memory::CWeakPointer<CBackend> backend_);

virtual Hyprutils::Memory::CSharedPointer<IBuffer> acquire(const SAllocatorBufferParams& params, Hyprutils::Memory::CSharedPointer<CSwapchain> swapchain_);
Expand Down
2 changes: 1 addition & 1 deletion include/aquamarine/backend/Backend.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ namespace Aquamarine {
/* Create a backend, with the provided options. May return a single or a multi-backend. */
static Hyprutils::Memory::CSharedPointer<CBackend> create(const std::vector<SBackendImplementationOptions>& backends, const SBackendOptions& options);

~CBackend();
~CBackend() = default;

/* start the backend. Initializes all the stuff, and will return true on success, false on fail. */
bool start();
Expand Down
2 changes: 1 addition & 1 deletion include/aquamarine/backend/Headless.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace Aquamarine {

class CHeadlessBackend : public IBackendImplementation {
public:
virtual ~CHeadlessBackend();
virtual ~CHeadlessBackend() = default;
virtual eBackendType type();
virtual bool start();
virtual std::vector<Hyprutils::Memory::CSharedPointer<SPollFD>> pollFDs();
Expand Down
4 changes: 2 additions & 2 deletions include/aquamarine/backend/Wayland.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ namespace Aquamarine {
class CWaylandKeyboard : public IKeyboard {
public:
CWaylandKeyboard(Hyprutils::Memory::CSharedPointer<CCWlKeyboard> keyboard_, Hyprutils::Memory::CWeakPointer<CWaylandBackend> backend_);
virtual ~CWaylandKeyboard();
virtual ~CWaylandKeyboard() = default;

virtual const std::string& getName();

Expand All @@ -109,7 +109,7 @@ namespace Aquamarine {
class CWaylandPointer : public IPointer {
public:
CWaylandPointer(Hyprutils::Memory::CSharedPointer<CCWlPointer> pointer_, Hyprutils::Memory::CWeakPointer<CWaylandBackend> backend_);
virtual ~CWaylandPointer();
virtual ~CWaylandPointer() = default;

virtual const std::string& getName();

Expand Down
4 changes: 0 additions & 4 deletions src/allocator/DRMDumb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,6 @@ void Aquamarine::CDRMDumbBuffer::endDataPtr() {
; // nothing to do
}

Aquamarine::CDRMDumbAllocator::~CDRMDumbAllocator() {
; // nothing to do
}

SP<CDRMDumbAllocator> Aquamarine::CDRMDumbAllocator::create(int drmfd_, Hyprutils::Memory::CWeakPointer<CBackend> backend_) {
if (drmGetNodeTypeFromFd(drmfd_) != DRM_NODE_PRIMARY) {
backend_->log(AQ_LOG_ERROR, "DRM Dumb: Cannot create allocator when drmfd is not the primary node");
Expand Down
4 changes: 0 additions & 4 deletions src/backend/Backend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,6 @@ Hyprutils::Memory::CSharedPointer<CBackend> Aquamarine::CBackend::create(const s
return backend;
}

Aquamarine::CBackend::~CBackend() {
;
}

bool Aquamarine::CBackend::start() {
log(AQ_LOG_DEBUG, "Starting the Aquamarine backend!");

Expand Down
4 changes: 0 additions & 4 deletions src/backend/Headless.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ bool Aquamarine::CHeadlessOutput::destroy() {
return true;
}

Aquamarine::CHeadlessBackend::~CHeadlessBackend() {
;
}

Aquamarine::CHeadlessBackend::CHeadlessBackend(SP<CBackend> backend_) : backend(backend_) {
timers.timerfd = timerfd_create(CLOCK_MONOTONIC, TFD_CLOEXEC);
}
Expand Down
8 changes: 0 additions & 8 deletions src/backend/Wayland.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,6 @@ Aquamarine::CWaylandKeyboard::CWaylandKeyboard(SP<CCWlKeyboard> keyboard_, Hypru
});
}

Aquamarine::CWaylandKeyboard::~CWaylandKeyboard() {
;
}

const std::string& Aquamarine::CWaylandKeyboard::getName() {
return name;
}
Expand Down Expand Up @@ -300,10 +296,6 @@ Aquamarine::CWaylandPointer::CWaylandPointer(SP<CCWlPointer> pointer_, Hyprutils
pointer->setFrame([this](CCWlPointer* r) { events.frame.emit(); });
}

Aquamarine::CWaylandPointer::~CWaylandPointer() {
;
}

const std::string& Aquamarine::CWaylandPointer::getName() {
return name;
}
Expand Down