-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uwsm instructions #850
Conversation
Also, @Vladimir-csp tagging you to review in case I forgot to mention something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even know why these two are here. They're automatically set by Hyprland. As for XDG_SESSION_DESKTOP
, what uses it?
hyprland-wiki/pages/Configuring/Environment-variables.md
Lines 64 to 65 in ac31e2d
- `env = XDG_CURRENT_DESKTOP,Hyprland` | |
- `env = XDG_SESSION_TYPE,wayland` |
I think this section needs to be integrated in some shape or form. The "full experience" is to place compositor unit in |
IIRC Hyprland passes them through if not mentioned in config, but already present in the environment (typical for DM/SM setup). ...yep
Systemd uses it, described in |
Makes sense to put it on a specific page I mentioned in the initial comment. Although, honestly, I didn't try uwsm app and not 100% sure how it works. |
Oops, I messed up this one. |
Systemd-managed session implies running apps in units. If something is spawned directly by Hyprland, it will be a part of compositor's unit which is not ideal (to say the least). Also it is recommended to put compositor into Apps (also things that do not have a systemd unit, run continuously, and are not related to the compositor) need to be wrapped in units by executing them via
Unit type is scope by default, because it behaves like simple commands. But it can be switched to service to gain more flexibility and journald logging.
|
IMHO, needs to be shortened and simplified, so we could add a quick instruction ( see https://wiki.hyprland.org/Useful-Utilities/). Long version is better to be put somewhere in readme on uwsm side, so we could provide a link to it. Speaking of adding another page for uwsm @fufexan should it be done by me, in this pr, or somehow else? Alternately, though, we could put uwsm in "Other" or "Must have" section |
You can create a new page under Useful Utilities in this PR. |
Oh wait, I just noticed Hyprland wiki already mentions uwsm. https://wiki.hyprland.org/Useful-Utilities/Other/ Should I keep the new page or leave just that mention? |
Keep the new page, and remove the mention from Other. |
Okay, done. I'll revisit the page later to add installation instructions and links to other wiki pages, if needed. |
Uh, I'm an idiot. My bad.
Force of habit UPD: chaining multiple commands within one exec-once works, btw |
No ATM, since flatpak handles units its own way.
It's shell, so why not. |
Plus, things like telegram and easy effects are meant to be autostarted with xdg-autostart, using desktop entries, but xdph doesn't allow that, for now. Also, another problem I should probably report to uwsm github (will do it tomorrow) - Hyprland no longer exits via loginctl command, immediately. All systemd services are stopped, but Hyprland, itself (and flatpak apps) stays active with its default wallpaper placeholder, for like a minute or two, before logging me out. I'll try to reproduce it tomorrow, though. As for the PR, itself - I'll add an example |
Co-authored-by: Vladimir-csp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nothing that can't be fixed later.
Why? |
Because of lacking |
Ah, you mean flatpak itself can not put entries into ~/.config/autostart due to portal issues? |
Exactly. Additionally, in case of Easy Effects - if I try to access its settings and get a warning about lacking access to Background implementation - it won't stay as a background process, after I open it, then close, so I have to reset its settings in order to be able both daemonize and access it. |
@fufexan tagging for the final (probably) review |
Co-authored-by: Mihai Fufezan <[email protected]>
Co-authored-by: Vladimir-csp <[email protected]>
Co-authored-by: Vladimir-csp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting looks ok to me. Content-wise it's also good. Will defer to @Vladimir-csp for any content inconsistencies.
Hyprland builds fine without it. Also, Arch maintainers removed it from Hyprland PKGBUILD in extra repo.
I removed |
Hm. I've just realized I'm exploiting a vulnerability to bypass portal background permission and daemonize Easy Effects. Curious. |
hyprwm/Hyprland#8376 and hyprwm/Hyprland#8339 discussion
Probably, need to add another page to mention uwsm with short instructions. Startup or something
Corrections, reviews and suggestions are welcome.