Skip to content

Commit e1153ac

Browse files
authored
Python 2 to 3 migration changes: format strings (hdl#6)
Changed all the uses of .format to f-strings instead. Signed-off-by: Wouter van Verre <[email protected]>
1 parent a4fad04 commit e1153ac

File tree

3 files changed

+32
-29
lines changed

3 files changed

+32
-29
lines changed

hdlparse/minilexer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def run(self, text):
6666
m = pat.match(text, pos)
6767
if m:
6868
if action:
69-
log.debug('Match: {} -> {}'.format(m.group().strip(), action))
69+
log.debug(f"Match: {m.group().strip()} -> {action}")
7070

7171
yield (pos, m.end() - 1), action, m.groups()
7272

hdlparse/verilog_parser.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,15 @@ def __init__(self, name, mode=None, data_type=None, default_value=None, desc=Non
8080

8181
def __str__(self):
8282
if self.mode is not None:
83-
param = '{} : {} {}'.format(self.name, self.mode, self.data_type)
83+
param = f"{self.name} : {self.mode} {self.data_type}"
8484
else:
85-
param = '{} : {}'.format(self.name, self.data_type)
85+
param = f"{self.name} : {self.data_type}"
8686
if self.default_value is not None:
87-
param = '{} := {}'.format(param, self.default_value)
87+
param = f"{param} := {self.default_value}"
8888
return param
8989

9090
def __repr__(self):
91-
return "VerilogParameter('{}')".format(self.name)
91+
return f"VerilogParameter('{self.name}')"
9292

9393

9494
class VerilogModule(VerilogObject):
@@ -103,7 +103,7 @@ def __init__(self, name, ports, generics=None, sections=None, desc=None):
103103
self.sections = sections if sections is not None else {}
104104

105105
def __repr__(self):
106-
return "VerilogModule('{}') {}".format(self.name, self.ports)
106+
return f"VerilogModule('{self.name}') {self.ports}"
107107

108108

109109
def parse_verilog_file(fname):

hdlparse/vhdl_parser.py

+26-23
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@
136136
(r'\n\s*\)\s*;\s*--(.*)\n', 'port_list_comment', '#pop:2'),
137137
(r'\n\s*', None),
138138
(r'\)\s*;', 'end_port', '#pop:2'),
139+
139140
(r'--#(.*)\n', 'metacomment'),
140141
(r'/\*', 'block_comment', 'block_comment'),
141142
],
@@ -193,18 +194,20 @@ def __init__(self, name, mode=None, data_type=None, default_value=None, desc=Non
193194

194195
def __str__(self):
195196
if self.mode is not None:
196-
param = '{} : {} {}'.format(self.name, self.mode, self.data_type.name + self.data_type.arange)
197+
param = f"{self.name} : {self.mode} {self.data_type.name + self.data_type.arange}"
197198
else:
198-
param = '{} : {}'.format(self.name, self.data_type.name + self.data_type.arange)
199+
param = f"{self.name} : {self.data_type.name + self.data_type.arange}"
200+
199201
if self.default_value is not None:
200-
param = '{} := {}'.format(param, self.default_value)
202+
param = f"{param} := {self.default_value}"
203+
201204
if self.param_desc is not None:
202-
param = '{} --{}'.format(param, self.param_desc)
205+
param = f"{param} --{self.param_desc}"
206+
203207
return param
204208

205209
def __repr__(self):
206-
return "VhdlParameter('{}', '{}', '{}')".format(self.name, self.mode,
207-
self.data_type.name + self.data_type.arange)
210+
return f"VhdlParameter('{self.name}', '{self.mode}', '{self.data_type.name + self.data_type.arange}')"
208211

209212

210213
class VhdlParameterType:
@@ -226,7 +229,7 @@ def __init__(self, name, direction="", r_bound="", l_bound="", arange=""):
226229
self.arange = arange
227230

228231
def __repr__(self):
229-
return "VhdlParameterType('{}','{}')".format(self.name, self.arange)
232+
return f"VhdlParameterType('{self.name}','{self.arange}')"
230233

231234

232235
class VhdlPackage(VhdlObject):
@@ -259,7 +262,7 @@ def __init__(self, name, package, type_of, desc=None):
259262
self.type_of = type_of
260263

261264
def __repr__(self):
262-
return "VhdlType('{}', '{}')".format(self.name, self.type_of)
265+
return f"VhdlType('{self.name}', '{self.type_of}')"
263266

264267

265268
class VhdlSubtype(VhdlObject):
@@ -279,7 +282,7 @@ def __init__(self, name, package, base_type, desc=None):
279282
self.base_type = base_type
280283

281284
def __repr__(self):
282-
return "VhdlSubtype('{}', '{}')".format(self.name, self.base_type)
285+
return f"VhdlSubtype('{self.name}', '{self.base_type}')"
283286

284287

285288
class VhdlConstant(VhdlObject):
@@ -299,7 +302,7 @@ def __init__(self, name, package, base_type, desc=None):
299302
self.base_type = base_type
300303

301304
def __repr__(self):
302-
return "VhdlConstant('{}', '{}')".format(self.name, self.base_type)
305+
return f"VhdlConstant('{self.name}', '{self.base_type}')"
303306

304307

305308
class VhdlFunction(VhdlObject):
@@ -321,7 +324,7 @@ def __init__(self, name, package, parameters, return_type=None, desc=None):
321324
self.return_type = return_type
322325

323326
def __repr__(self):
324-
return "VhdlFunction('{}')".format(self.name)
327+
return f"VhdlFunction('{self.name}')"
325328

326329

327330
class VhdlProcedure(VhdlObject):
@@ -341,7 +344,7 @@ def __init__(self, name, package, parameters, desc=None):
341344
self.parameters = parameters
342345

343346
def __repr__(self):
344-
return "VhdlProcedure('{}')".format(self.name)
347+
return f"VhdlProcedure('{self.name}')"
345348

346349

347350
class VhdlEntity(VhdlObject):
@@ -362,12 +365,12 @@ def __init__(self, name, ports, generics=None, sections=None, desc=None):
362365
self.sections = sections if sections is not None else {}
363366

364367
def __repr__(self):
365-
return "VhdlEntity('{}')".format(self.name)
368+
return f"VhdlEntity('{self.name}')"
366369

367370
def dump(self):
368-
print('VHDL entity: {}'.format(self.name))
371+
print(f"VHDL entity: {self.name}")
369372
for p in self.ports:
370-
print('\t{} ({}), {} ({})'.format(p.name, type(p.name), p.data_type, type(p.data_type)))
373+
print(f"\t{p.name} ({type(p.name)}), {p.data_type} ({type(p.data_type)})")
371374

372375

373376
class VhdlComponent(VhdlObject):
@@ -391,12 +394,12 @@ def __init__(self, name, package, ports, generics=None, sections=None, desc=None
391394
self.sections = sections if sections is not None else {}
392395

393396
def __repr__(self):
394-
return "VhdlComponent('{}')".format(self.name)
397+
return f"VhdlComponent('{self.name}')"
395398

396399
def dump(self):
397-
print('VHDL component: {}'.format(self.name))
400+
print(f"VHDL component: {self.name}")
398401
for p in self.ports:
399-
print('\t{} ({}), {} ({})'.format(p.name, type(p.name), p.data_type, type(p.data_type)))
402+
print(f"\t{p.name} ({type(p.name)}), {p.data_type} ({type(p.data_type)})")
400403

401404

402405
def parse_vhdl_file(fname):
@@ -641,12 +644,12 @@ def subprogram_prototype(vo):
641644

642645
if isinstance(vo, VhdlFunction):
643646
if len(vo.parameters) > 0:
644-
proto = 'function {}({}) return {};'.format(vo.name, plist, vo.return_type)
647+
proto = f"function {vo.name}({plist}) return {vo.return_type};"
645648
else:
646-
proto = 'function {} return {};'.format(vo.name, vo.return_type)
649+
proto = f"function {vo.name} return {vo.return_type};"
647650

648651
else: # procedure
649-
proto = 'procedure {}({});'.format(vo.name, plist)
652+
proto = f"procedure {vo.name}({plist});"
650653

651654
return proto
652655

@@ -665,10 +668,10 @@ def subprogram_signature(vo, fullname=None):
665668

666669
if isinstance(vo, VhdlFunction):
667670
plist = ','.join(p.data_type for p in vo.parameters)
668-
sig = '{}[{} return {}]'.format(fullname, plist, vo.return_type)
671+
sig = f"{fullname}[{plist} return {vo.return_type}]"
669672
else: # procedure
670673
plist = ','.join(p.data_type for p in vo.parameters)
671-
sig = '{}[{}]'.format(fullname, plist)
674+
sig = f"{fullname}[{plist}]"
672675

673676
return sig
674677

0 commit comments

Comments
 (0)