fix: CON-112 - Removing import * statements

Author: Marcus Baker

tests/connection.py

@@ -3,7 +3,7 @@
 
 import mongoengine.connection
 
-from mongoengine import *
+from mongoengine import connect, register_connection
 from mongoengine.connection import (
     get_db, get_connection, register_db, ConnectionError)
 

tests/dereference.py

@@ -1,6 +1,9 @@
 import unittest
 
-from mongoengine import *
+from mongoengine import (
+    StringField, ListField, MapField, DictField,
+    ReferenceField, GenericReferenceField,
+    Document, EmbeddedDocument, EmbeddedDocumentField)
 from mongoengine.connection import get_db, register_db, connect
 from mongoengine.tests import query_counter
 
@@ -271,8 +274,7 @@ class Group(Document):
 
         with query_counter() as q:
             self.assertEqual(q, 0)
-
-            group_obj = Group.objects.first()
+            Group.objects.first()
             self.assertEqual(q, 1)
 
         # Document select_related
@@ -334,8 +336,7 @@ class Group(Document):
 
         with query_counter() as q:
             self.assertEqual(q, 0)
-
-            group_obj = Group.objects.first()
+            Group.objects.first()
             self.assertEqual(q, 1)
 
         # Document select_related
@@ -518,8 +519,7 @@ class Group(Document):
 
         with query_counter() as q:
             self.assertEqual(q, 0)
-
-            group_obj = Group.objects.first()
+            Group.objects.first()
             self.assertEqual(q, 1)
 
         # Document select_related

tests/django_compatibility.py

@@ -3,7 +3,7 @@
 import unittest
 from distutils.version import StrictVersion
 
-from mongoengine import *
+from mongoengine import connect, Q, IntField, StringField, Document
 from mongoengine.connection import register_db
 from mongoengine.django.shortcuts import get_document_or_404
 
@@ -102,7 +102,7 @@ class Page(Document):
 
         paginator = Paginator(Page.objects.all(), 2)
 
-        t = Template("{% for i in page.object_list  %}{{ i.name }}:{% endfor %}")
+        t = Template("{% for i in page.object_list  %}{{ i.name }}:{% endfor %}")  # noqa
         for p in paginator.page_range:
             d = {"page": paginator.page(p)}
             end = p * 2

tests/document.py

@@ -9,7 +9,13 @@
 
 from fixtures import Base, PickleEmbedded, PickleTest
 
-from mongoengine import *
+from mongoengine import (
+    connect, Q, CASCADE, NULLIFY, DENY,
+    ValidationError, InvalidCollectionError, OperationError,
+    StringField, IntField, BooleanField, DateTimeField, EmailField,
+    ListField, MapField, DictField,
+    ReferenceField, GenericReferenceField,
+    Document, DynamicDocument, EmbeddedDocument, EmbeddedDocumentField)
 from mongoengine.base import NotRegistered, InvalidDocumentError
 from mongoengine.queryset import InvalidQueryError
 from mongoengine.connection import get_db, register_db
@@ -177,10 +183,18 @@ def test_get_superclasses(self):
         """
         class Animal(Document):
             meta = {'allow_inheritance': True}
-        class Fish(Animal): pass
-        class Mammal(Animal): pass
-        class Human(Mammal): pass
-        class Dog(Mammal): pass
+
+        class Fish(Animal):
+            pass
+
+        class Mammal(Animal):
+            pass
+
+        class Human(Mammal):
+            pass
+
+        class Dog(Mammal):
+            pass
 
         mammal_superclasses = {'Animal': Animal}
         self.assertEqual(Mammal._superclasses, mammal_superclasses)
@@ -195,11 +209,20 @@ def test_external_superclasses(self):
         """Ensure that the correct list of sub and super classes is assembled.
         when importing part of the model
         """
-        class Animal(Base): pass
-        class Fish(Animal): pass
-        class Mammal(Animal): pass
-        class Human(Mammal): pass
-        class Dog(Mammal): pass
+        class Animal(Base):
+            pass
+
+        class Fish(Animal):
+            pass
+
+        class Mammal(Animal):
+            pass
+
+        class Human(Mammal):
+            pass
+
+        class Dog(Mammal):
+            pass
 
         mammal_superclasses = {'Base': Base, 'Base.Animal': Animal}
         self.assertEqual(Mammal._superclasses, mammal_superclasses)
@@ -229,10 +252,18 @@ def test_polymorphic_queries(self):
         """
         class Animal(Document):
             meta = {'allow_inheritance': True}
-        class Fish(Animal): pass
-        class Mammal(Animal): pass
-        class Human(Mammal): pass
-        class Dog(Mammal): pass
+
+        class Fish(Animal):
+            pass
+
+        class Mammal(Animal):
+            pass
+
+        class Human(Mammal):
+            pass
+
+        class Dog(Mammal):
+            pass
 
         Animal.drop_collection()
 
@@ -294,8 +325,12 @@ class Employee(self.Person):
         # Ensure that MRO error is not raised
         class A(Document):
             meta = {'allow_inheritance': True}
-        class B(A): pass
-        class C(B): pass
+
+        class B(A):
+            pass
+
+        class C(B):
+            pass
 
     def test_allow_inheritance(self):
         """Ensure that inheritance may be disabled on simple classes and that
@@ -768,6 +803,7 @@ def test_save(self):
         self.assertEqual(person_obj['name'], 'Test User')
         self.assertEqual(person_obj['age'], 30)
         self.assertEqual(person_obj['_id'], person.id)
+
         # Test skipping validation on save
         class Recipient(Document):
             email = EmailField(required=True)
@@ -1047,7 +1083,6 @@ class Page(EmbeddedDocument):
         class Site(Document):
             page = EmbeddedDocumentField(Page)
 
-
         Site.drop_collection()
         site = Site(page=Page(log_message="Warning: Dummy message"))
         site.save()
@@ -1253,12 +1288,14 @@ class Doc(Document):
             ({'embedded_field.list_field.2.string_field': 'world'}, {}))
         doc.save()
         doc = doc.reload(10)
-        self.assertEquals(doc.embedded_field.list_field[2].string_field, 'world')
+        self.assertEquals(doc.embedded_field.list_field[2].string_field,
+                          'world')
 
         # Test multiple assignments
         doc.embedded_field.list_field[2].string_field = 'hello world'
         doc.embedded_field.list_field[2] = doc.embedded_field.list_field[2]
-        self.assertEquals(doc._get_changed_fields(), ['embedded_field.list_field'])
+        self.assertEquals(doc._get_changed_fields(),
+                          ['embedded_field.list_field'])
         self.assertEquals(
             doc.embedded_field._delta(),
             ({'list_field': [
@@ -1314,12 +1351,16 @@ class Doc(Document):
             [1, 2, {'hello': 'world'}])
 
         del(doc.embedded_field.list_field[2].list_field[2]['hello'])
-        self.assertEquals(doc._delta(), ({'embedded_field.list_field.2.list_field': [1, 2, {}]}, {}))
+        self.assertEquals(
+            doc._delta(),
+            ({'embedded_field.list_field.2.list_field': [1, 2, {}]}, {}))
         doc.save()
         doc = doc.reload(10)
 
         del(doc.embedded_field.list_field[2].list_field)
-        self.assertEquals(doc._delta(), ({}, {'embedded_field.list_field.2.list_field': 1}))
+        self.assertEquals(
+            doc._delta(),
+            ({}, {'embedded_field.list_field.2.list_field': 1}))
 
         doc.save()
         doc = doc.reload(10)
@@ -1413,7 +1454,8 @@ class Doc(Document):
             int_field = IntField(db_field='db_int_field')
             dict_field = DictField(db_field='db_dict_field')
             list_field = ListField(db_field='db_list_field')
-            embedded_field = EmbeddedDocumentField(Embedded, db_field='db_embedded_field')
+            embedded_field = EmbeddedDocumentField(
+                Embedded, db_field='db_embedded_field')
 
         Doc.drop_collection()
         doc = Doc()
@@ -1943,8 +1985,10 @@ def test_reverse_delete_rule_cascade_and_nullify_complex_field(self):
 
         class BlogPost(Document):
             content = StringField()
-            authors = ListField(ReferenceField(self.Person, reverse_delete_rule=CASCADE))
-            reviewers = ListField(ReferenceField(self.Person, reverse_delete_rule=NULLIFY))
+            authors = ListField(ReferenceField(self.Person,
+                                               reverse_delete_rule=CASCADE))
+            reviewers = ListField(ReferenceField(self.Person,
+                                                 reverse_delete_rule=NULLIFY))
 
         self.Person.drop_collection()
         BlogPost.drop_collection()
@@ -1973,8 +2017,10 @@ def test_invalid_reverse_delete_rules_raise_errors(self):
         def throw_invalid_document_error():
             class Blog(Document):
                 content = StringField()
-                authors = MapField(ReferenceField(self.Person, reverse_delete_rule=CASCADE))
-                reviewers = DictField(field=ReferenceField(self.Person, reverse_delete_rule=NULLIFY))
+                authors = MapField(ReferenceField(self.Person,
+                                                  reverse_delete_rule=CASCADE))
+                reviewers = DictField(field=ReferenceField(
+                    self.Person, reverse_delete_rule=NULLIFY))
 
         self.assertRaises(InvalidDocumentError, throw_invalid_document_error)
 
@@ -2043,8 +2089,8 @@ class BlogPost(Document):
         post.save()
 
         # Delete the Person should be denied
-        self.assertRaises(OperationError, author.delete)  # Should raise denied error
-        self.assertEqual(len(BlogPost.objects), 1)  # No objects may have been deleted
+        self.assertRaises(OperationError, author.delete)  # Should raise denied
+        self.assertEqual(len(BlogPost.objects), 1)  # No objects deleted?
         self.assertEqual(len(self.Person.objects), 1)
 
         # Other users, that don't have BlogPosts must be removable, like normal
@@ -2364,15 +2410,16 @@ def __str__(self):
             u",".join([str(b) for b in
                        Book.objects.filter(Q(extra__a=bob) |
                                            Q(author=bob) |
-                                           Q(extra__b=bob))]) ,
+                                           Q(extra__b=bob))]),
             "1,2,3,4")
 
         # Susan & Karl related books
-        self.assertEqual(u",".join([str(b) for b in Book.objects.filter(
-                                    Q(extra__a__all=[karl, susan] ) |
-                                    Q(author__all=[karl, susan ] ) |
-                                    Q(extra__b__all=[karl.to_dbref(), susan.to_dbref()] )
-                                    ) ] ) , "1" )
+        self.assertEqual(
+            u",".join([str(b) for b in Book.objects.filter(
+                        Q(extra__a__all=[karl, susan]) |
+                        Q(author__all=[karl, susan]) |
+                        Q(extra__b__all=[karl.to_dbref(), susan.to_dbref()]))]),
+            "1")
 
         # $Where
         self.assertEqual(
@@ -2422,6 +2469,5 @@ def __init__(self, id, name):
         self.assertTrue(a != somethingElse)
 
 
-
 if __name__ == '__main__':
     unittest.main()

tests/dynamic_document.py

@@ -1,6 +1,8 @@
 import unittest
 
-from mongoengine import *
+from mongoengine import (
+    connect, StringField, IntField,
+    DynamicDocument, DynamicEmbeddedDocument)
 from mongoengine.connection import get_db, register_db
 
 
@@ -189,7 +191,8 @@ class Doc(DynamicDocument):
         self.assertEquals(doc.embedded_field.string_field, "hello")
         self.assertEquals(doc.embedded_field.int_field, 1)
         self.assertEquals(doc.embedded_field.dict_field, {'hello': 'world'})
-        self.assertEquals(doc.embedded_field.list_field, ['1', 2, {'hello': 'world'}])
+        self.assertEquals(doc.embedded_field.list_field,
+                          ['1', 2, {'hello': 'world'}])
 
     def test_complex_embedded_documents(self):
         """Test complex dynamic embedded documents setups"""